feat(admins): soft-retire, durable issuer names, and bulk actions (#1509) - #1548
Closed
maxijabase wants to merge 20 commits into
Closed
feat(admins): soft-retire, durable issuer names, and bulk actions (#1509)#1548maxijabase wants to merge 20 commits into
maxijabase wants to merge 20 commits into
Conversation
…pp#1509) Close deactivate/reactivate polish plus admins.bulk with list checkboxes, keeping ban/comm Admin cells on snapshot names after hard delete.
Contributor
Author
|
Closed: opened from an agent plan todo without an explicit maintainer request. Branch remains on the fork if we want to open this later. |
Use the same ghost icon button pattern as deactivate/delete so inactive rows do not show a bordered labeled control.
Replace OS caret inconsistency with a progressive .ssel enhancer sharing Lucide chevron chrome with .msel, and keep narrow grid tracks from overflowing.
One eye control reveals password and confirm together; generate still resets to masked.
Open upward when there is more room above the trigger, and shrink max-height to the available viewport space.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #1509 in one PR:
admins.enabledwithadmins.deactivate/admins.reactivate, Active/Inactive/All chips, auth + SourceMod fail-closed for inactive admins.bans.admin_name/comms.admin_name(migration 811) snapshotted on hard delete and on write; banlist/commslist Admin cells show the snapshot or Unknown, never "deleted admin" for the issuer.admins.bulk(deactivate|reactivate|remove|set_web_group|set_srv_group) with partialapplied/skippedresults. Self and owner guards match single-row ops.Also regenerates
api-contract.js, adds API snapshots, PermissionMatrix row, and E2E coverage.Motivation and Context
Ex-admins should leave without wiping historical issuer names, and operators need a reversible soft-retire path plus multi-select lifecycle / group assign on the admins list. Fixes #1509.
How Has This Been Tested?
AdminsTest|PermissionMatrixTest|AdminEnabledAttributionTestadmin-deactivate-bulk.spec.ts(deactivate/reactivate, hard-delete issuer snapshot on banlist, bulk deactivate, bulk assign web group) againstsourcebans_e2eScreenshots (if appropriate):
Types of changes
Checklist: