Improve admin Groups page UX (row actions, cards, client select, edit chrome) - #1551
Open
maxijabase wants to merge 7 commits into
Open
Improve admin Groups page UX (row actions, cards, client select, edit chrome)#1551maxijabase wants to merge 7 commits into
maxijabase wants to merge 7 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Polishes the admin Groups management surfaces so they match the rest of the v2 panel chrome and feel faster to operate day to day.
List page (
?p=admin&c=groups§ion=list)btn+ Lucidetrash-2/pencil, danger styling on Delete) across Web Admin, Server Admin, and Server Groups..space-y-2utility so stacked server tiles are no longer stuck together with no gap.history.pushState) without a full page reload. Dirty-form confirmation still guards unsaved flag edits. No-JS keeps the existing?gid=links.Edit Group (
o=edit)Tests
EditGroupChromeTest,WebGroupsCatalogTestadmin-groups-client-select.spec.ts, trash-icon assertion on the existing delete flowMotivation and Context
The Groups list lagged behind bans / admins / mods after the v2 rewrite: weak action affordances, cramped Server Admin cards, zero spacing between Server Group tiles, full reloads for every Web Admin Group click, and an Edit Group page that did not match the newer permissions UI. This PR closes that gap without changing group semantics or adding new APIs.
How Has This Been Tested?
sbpp-webon:8080) against seededsourcebansdataEditGroupChromeTest+WebGroupsCatalogTestadmin-groups-client-selectandadmin-groups-deleteScreenshots (if appropriate):
Before
chrome_wczVx4enRE.mp4
After
chrome_F4uTeeG68h.mp4
Types of changes
Checklist: