Clean up review findings: remove dead clarification code, fix stale version, honest max_turns docs#54
Merged
Merged
Conversation
…ersion, honest max_turns docs - Remove unused execution/clarification.py (check_clarification had zero callers and was never wired into the Copilot path) plus its README claims. - Correct CopilotEval max_turns docstrings: the runner enforces timeout_s; max_turns is advisory (not hard-enforced mid-run) and caps subagent turns. - Bump pyproject version 0.5.7 -> 0.6.14 and classifier Alpha -> Beta. - Roll CHANGELOG [Unreleased] into a dated [0.6.13] section; add new entries. - git-ignore the .pytest-execution-servers/ test scratch directory. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: afaf3899-ebf3-4aef-930d-989f2eadaeb4
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acts on the expert repo review. Small, focused cleanup — no behavior change to shipped features.
Changes
Removed dead code
execution/clarification.py(check_clarification). It had zero callers anywhere in the codebase and was never wired into the Copilot execution path, yet "clarification detection" was advertised in the README. Removed the module and the two README claims to keep docs honest (per the repo's no-dead-code policy).Honest docs for
max_turnsCopilotEvaldocstrings claimed the runner "enforces turn limits externally". It does not — the runner enforcestimeout_s(hard wall-clock limit).max_turnsis advisory for the top-level session and is only used to cap subagent turns. Docstrings corrected to match reality.Packaging hygiene
pyproject.tomlversion0.5.7→0.6.14(was 8 releases stale; the release workflow derives version from git tags so the committed value had drifted).Development Status :: 3 - Alpha→4 - Beta.Housekeeping
CHANGELOG.md[Unreleased]into a dated[0.6.13]section and add entries for this PR..pytest-execution-servers/scratch directory some server tests create.Verification (WSL venv — native ARM64 can't build deps)
ruff check✅ruff format --check✅pyright src✅ (0 errors)pytest tests/unit✅ 520 passed