Skip to content

Remove components: native-image for GraalVM Distribution (JDK 17+) #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guizmaii wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove components: native-image for GraalVM Distribution (JDK 17+) #212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/scala/sbtghactions/WorkflowStep.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,14 +64,15 @@ object WorkflowStep {
"github-token" -> s"$${{ secrets.GITHUB_TOKEN }}",
"cache" -> "sbt"))
case jv @ JavaSpec(JavaSpec.Distribution.GraalVM(Graalvm.Distribution(distribution)), version) =>
// Note: native-image is included by default in GraalVM for JDK 17+
// See: https://github.com/oracle/graal/pull/5995
WorkflowStep.Use(
Action.setupGraalvm,
name = Some(s"Setup GraalVM (${jv.render})"),
cond = Some(s"matrix.java == '${jv.render}'"),
params = ListMap(
"java-version" -> s"$version",
"distribution" -> distribution,
"components" -> "native-image",
"github-token" -> s"$${{ secrets.GITHUB_TOKEN }}",
"cache" -> "sbt"))
case jv @ JavaSpec(dist, version) =>
Expand Down
5 changes: 3 additions & 2 deletions src/test/scala/sbtghactions/GenerativePluginSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,7 +594,9 @@ class GenerativePluginSpec extends Specification {
javas = javas),
"")

results mustEqual s"""abc:
// Note: components: native-image is not included for Graalvm.Distribution
// because native-image is bundled by default in GraalVM for JDK 17+
results mustEqual s"""abc:
name: How to get to...
strategy:
matrix:
Expand All @@ -609,7 +611,6 @@ class GenerativePluginSpec extends Specification {
with:
java-version: 17
distribution: graalvm
components: native-image
github-token: $${{ secrets.GITHUB_TOKEN }}
cache: sbt"""
}
Expand Down
Loading