Common mistakes#3
Open
CryptoOnion wants to merge 23 commits into
Open
Conversation
CryptoOnion
commented
Jun 8, 2020
| for (line <- scala.io.Source.stdin.getLines) { | ||
| message.fire(line) | ||
| } | ||
| } |
Author
There was a problem hiding this comment.
Suggested change
| } |
@JanisMittelstaedt I guess this one is not needed here.
We already have one open and close brace for the for-loop and a closing one later for the method.
pweisenburger
requested changes
Jun 14, 2020
pweisenburger
left a comment
There was a problem hiding this comment.
see comments on files for some smaller changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the project we used the papers and including this project for getting started with the framework. We encountered some issues on our own and thought it makes the sense to improve it based on our experience.
Some parts of the papers were outdated and some minor things in this project too. Here is a summary of the changes we did:
Summary
Added:
mainmethodRemote[*]localsyntaxFutures for missing importsupickleexample (package declaration vs our companion objects)Clarify
Optionalpeer definitions usageFixes:
packagedeclarationUpdated: