Skip to content

feat: add support for windows server#329

Merged
remyleone merged 3 commits into
scaleway:mainfrom
Mia-Cross:feat_windows_support
Jun 17, 2026
Merged

feat: add support for windows server#329
remyleone merged 3 commits into
scaleway:mainfrom
Mia-Cross:feat_windows_support

Conversation

@Mia-Cross

Copy link
Copy Markdown
Contributor

Closes #319

@Mia-Cross Mia-Cross self-assigned this Jun 8, 2026
@Mia-Cross Mia-Cross force-pushed the feat_windows_support branch 4 times, most recently from 49c8a15 to 99a4534 Compare June 12, 2026 13:58
@Mia-Cross Mia-Cross force-pushed the feat_windows_support branch 2 times, most recently from e9620ab to 680f9f8 Compare June 12, 2026 15:49
@Mia-Cross Mia-Cross force-pushed the feat_windows_support branch from 680f9f8 to c5a81d9 Compare June 15, 2026 17:52
@Mia-Cross Mia-Cross force-pushed the feat_windows_support branch from f42dbda to 997e05b Compare June 16, 2026 12:10
@Mia-Cross Mia-Cross marked this pull request as ready for review June 16, 2026 12:24
@Mia-Cross Mia-Cross requested a review from remyleone as a code owner June 16, 2026 12:24
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 106 lines in your changes missing coverage. Please review.
✅ Project coverage is 7.54%. Comparing base (665c1de) to head (997e05b).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
builder/scaleway/config.hcl2spec.go 0.00% 86 Missing ⚠️
internal/checks/server.go 0.00% 16 Missing ⚠️
builder/scaleway/step_create_server.go 0.00% 2 Missing ⚠️
internal/tester/tester.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #329      +/-   ##
========================================
- Coverage   7.62%   7.54%   -0.09%     
========================================
  Files         38      38              
  Lines       1586    1604      +18     
========================================
  Hits         121     121              
- Misses      1441    1459      +18     
  Partials      24      24              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@remyleone remyleone added this pull request to the merge queue Jun 17, 2026
Merged via the queue into scaleway:main with commit db52e54 Jun 17, 2026
7 checks passed
@Mia-Cross Mia-Cross deleted the feat_windows_support branch June 22, 2026 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Windows instance creation in the Scaleway Packer plugin (with-ssh and IAM SSH key ID)

3 participants