COSI-99: fix: quote COSI controller install URL across docs and CI for cross-shell compatibility#199
Merged
anurag4DSB merged 1 commit intoJun 23, 2026
Conversation
anurag4DSB
requested review from
fredmnl,
leif-scality and
nicolas2bert
and removed request for
a team
anurag4DSB
changed the title
anurag4DSB
force-pushed
the
bugfix/COSI-99-quote-cosi-controller-install-command
branch
from
a3f624c to
765cee1
Compare
The documented `kubectl create -k github.com/...?ref=v0.2.2` command fails in zsh (the macOS default) and tcsh/csh because the unquoted `?` is treated as a filename glob (`no matches found`). Quote the URL and add kustomize's `//` repo-root separator so it works in every shell. Applied everywhere the command appears: the quickstart in README.md and docs/installation/install-helm.md, and the three CI call sites (setup/cleanup scripts and the helm-validation workflow) so docs and CI stay aligned and the quoted form is exercised on every run.
anurag4DSB
force-pushed
the
bugfix/COSI-99-quote-cosi-controller-install-command
branch
from
765cee1 to
fa5465a
Compare
anurag4DSB
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
@@ Coverage Diff @@
## main #199 +/- ##
=======================================
Coverage 92.73% 92.73%
=======================================
Files 14 14
Lines 647 647
=======================================
Hits 600 600
Misses 38 38
Partials 9 9 🚀 New features to boost your workflow:
|
tcarmet
approved these changes
Jun 19, 2026
fredmnl
approved these changes
Jun 22, 2026
anurag4DSB
deleted the
bugfix/COSI-99-quote-cosi-controller-install-command
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous command runs successfully on bash (CI runner) bit fails on ZSH.
This new command has been tested in zsh,tcsh,csh and CI tests it on bash, hence the CI change