feat(storcli2): logical volume drive add (expand) and remove#70
Open
g-carre wants to merge 2 commits into
Open
feat(storcli2): logical volume drive add (expand) and remove#70g-carre wants to merge 2 commits into
g-carre wants to merge 2 commits into
Conversation
Complete ports.LogicalVolumesManager on the storcli2/perccli2 manager:
- AddPDsToLV grows a volume through "expand drives=e:s,..." (online capacity
expansion). storcli2 dropped "start migrate", so expansion is the only
supported growth path; the firmware preserves the RAID level. Drives
spanning multiple enclosures are rejected.
- DeletePDsFromLV returns ErrFunctionNotSupportedByImplementation: the
storcli-to-storcli2 command map drops "start migrate" with no replacement
for removing drives from a volume (see DESIGN.md).
Replace the stale plain-text migrate/fail.json fixture (captured with the
v1 grammar that storcli2 rejects) with proper expand/{success,fail}.json
fixtures, and update the collection script and testdata README accordingly.
Issue: ARTESCA-17648
revive's unused-receiver rule flagged the named 's' receiver, which the not-supported stub never references. Issue: ARTESCA-17648
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes
ports.LogicalVolumesManageron the storcli2/perccli2 manager (ARTESCA-17648). Stacked on #69.storcli2 dropped storcli's
start migratecommand (perDESIGN.md, verified against the StorCLI2 User Guide and the official storcli-to-storcli2 command map), so the two drive-membership operations split:AddPDsToLV— online capacity expansion via/cx/vx expand drives=e:s,.... The firmware preserves the RAID level; drives spanning multiple enclosures are rejected.DeletePDsFromLV— returnsports.ErrFunctionNotSupportedByImplementation: there is no storcli2 replacement forstart migrate option=remove.Replaces the stale plain-text
migrate/fail.jsonfixture (aunexpected TOKEN_MIGRATEsyntax error provingstart migrateno longer parses) with properexpand/{success,fail}.jsonfixtures, and updates the collection script and testdata README.Testing
go build,go vet,gofmt, and the package test suite pass. New tests cover the expand happy path, command-failure, multi-enclosure rejection, and the unsupported-removal error.Issue: ARTESCA-17648
🤖 Generated with Claude Code