Skip to content

bf: SPRXCLT-20 handle 404 error appropriately #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bert-e merged 2 commits into from
Oct 17, 2025
Merged

bf: SPRXCLT-20 handle 404 error appropriately #310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e795e6
bf: SPRXCLT-20 handle 404 error appropriately
jonathan-gramain Oct 16, 2025
48bfb23
SPRXCLT-20 bump version
jonathan-gramain Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions lib/sproxyd.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,15 +378,19 @@ class SproxydClient {
: contentType;
const request = _createRequest(req, log, (err, response) => {
if (err) {
if (err.code === 404) {
log.debug('sproxyd responded with error 404 not found');
return callback(err);
}
const errorProcessed = err;
// non-streaming are always retryable;
errorProcessed.retryable = true;
log.error('error sending sproxyd request', {
log.error('error during sproxyd request', {
error: errorProcessed,
});
return callback(errorProcessed);
}
log.debug('success sending sproxyd request', {
log.debug('success of sproxyd request', {
statusCode: response.statusCode,
});
return callback(null, response);
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"engines": {
"node": ">=20"
},
"version": "8.1.0",
"version": "8.1.1",
"description": "sproxyd client",
"main": "index.js",
"scripts": {
Expand Down
1 change: 0 additions & 1 deletion tests/unit/sproxyd.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,6 @@ const clientImmutableWithFailover = new Sproxy({
const error = new Error();
error.isExpected = true;
error.code = 404;
error.retryable = true;
assert.deepStrictEqual(err, error,
'Doesn\'t fail properly');
done();
Expand Down