Skip to content

SPRXCLT-24: add putUserMetadata method#313

Merged
bert-e merged 2 commits into
development/9from
improvement/SPRXCLT-24-put-user-metadata
May 29, 2026
Merged

SPRXCLT-24: add putUserMetadata method#313
bert-e merged 2 commits into
development/9from
improvement/SPRXCLT-24-put-user-metadata

Conversation

@jonathan-gramain

Copy link
Copy Markdown
Contributor

Summary

  • Add putUserMetadata(key, metadata, reqUids, callback) method that updates an object's user metadata in-place by sending a zero-byte PUT with x-scal-cmd: update-usermd, without replacing the object's content
  • Add unit test covering the new method: verifies both that the metadata is updated and that the existing object content is preserved
  • Update the unit test server handler to simulate the x-scal-cmd: update-usermd sproxyd behaviour (metadata-only update, content body untouched)

Test plan

  • npm test passes (85 tests)
  • New test runs across all four client variants (immutable, non-immutable, with and without failover)

🤖 Generated with Claude Code

@bert-e

bert-e commented May 29, 2026

Copy link
Copy Markdown
Contributor

Hello jonathan-gramain,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e

bert-e commented May 29, 2026

Copy link
Copy Markdown
Contributor

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

jonathan-gramain and others added 2 commits May 29, 2026 10:39
Add putUserMetadata() which sends a zero-byte PUT with x-scal-cmd:
update-usermd to update an object's user metadata without replacing its
content. Update the unit test handler to simulate this sproxyd behavior,
and add a test that verifies both the metadata update and content
preservation.

Pass the full response through _failover/_handleRequest using rest params
so put() can extract and return x-scal-version from the response headers.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@jonathan-gramain jonathan-gramain force-pushed the improvement/SPRXCLT-24-put-user-metadata branch from aa3b952 to 1690650 Compare May 29, 2026 17:40
@jonathan-gramain

Copy link
Copy Markdown
Contributor Author

/approve

@bert-e

bert-e commented May 29, 2026

Copy link
Copy Markdown
Contributor

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/9

The following branches have NOT changed:

  • development/6.4
  • development/7.10
  • development/7.4
  • development/8.0
  • development/8.1
  • development/8.2

Please check the status of the associated issue SPRXCLT-24.

Goodbye jonathan-gramain.

The following options are set: approve

@bert-e bert-e merged commit 1690650 into development/9 May 29, 2026
1 check passed
@bert-e bert-e deleted the improvement/SPRXCLT-24-put-user-metadata branch May 29, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants