Per-node UBO population and per-frame cam state access#676
Open
skalarproduktraum wants to merge 2 commits into
Open
Per-node UBO population and per-frame cam state access#676skalarproduktraum wants to merge 2 commits into
skalarproduktraum wants to merge 2 commits into
Conversation
…populate UBOs on their own
…that is attached to a pass
smlpt
reviewed
Feb 20, 2024
| return true | ||
| } | ||
|
|
||
| override var nodeType = "Node" |
Contributor
There was a problem hiding this comment.
Will this cause any trouble in other parts of scenery that rely on this node type?
Or rather: will removing the property nodeType altogether result in any unexpected behavior in other parts of scenery?
smlpt
reviewed
Feb 20, 2024
| } | ||
| } | ||
|
|
||
| var stereoEnabled = false |
Contributor
There was a problem hiding this comment.
Why is this false if it is a stereo camera?
smlpt
requested changes
Feb 20, 2024
smlpt
left a comment
smlpt
left a comment
Contributor
There was a problem hiding this comment.
Looks good, but maybe add a short documentation to the populate UBO classes?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces:
PopulatesUBOinterface, which enables node to define their own serialisation procedure, aka, how to translate a node's information into something accessible to shaders that goes beyond ShaderProperties