Skip to content

Fix for integer overflow bug in binary search. #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dpsi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix for integer overflow bug in binary search. #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions lbtree-src/lbtree.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,7 +466,6 @@ void * lbtree::lookup (key_type key, int *pos)
bnode *p;
bleaf *lp;
int i,t,m,b;
key_type r;

unsigned char key_hash= hashcode1B(key);
int ret_pos;
Expand All @@ -490,9 +489,8 @@ void * lbtree::lookup (key_type key, int *pos)
b=1; t=p->num();
while (b+7<=t) {
m=(b+t) >>1;
r= key - p->k(m);
if (r>0) b=m+1;
else if (r<0) t = m-1;
if (key > p->k(m)) b=m+1;
else if (key < p->k(m)) t = m-1;
else {p=p->ch(m); goto inner_done;}
}

Expand Down Expand Up @@ -605,7 +603,6 @@ void lbtree::insert (key_type key, void *ptr)
{ bnode *p;
bleaf *lp;
int i,t,m,b;
key_type r;

Again2:
// 1. RTM begin
Expand Down Expand Up @@ -634,9 +631,8 @@ void lbtree::insert (key_type key, void *ptr)
b=1; t=p->num();
while (b+7<=t) {
m=(b+t) >>1;
r= key - p->k(m);
if (r>0) b=m+1;
else if (r<0) t = m-1;
if (key > p->k(m)) b=m+1;
else if (key < p->k(m)) t = m-1;
else {p=p->ch(m); ppos[i]=m; goto inner_done;}
}

Expand Down Expand Up @@ -998,7 +994,6 @@ void lbtree::del (key_type key)
{ bnode *p;
bleaf *lp;
int i,t,m,b;
key_type r;

Again3:
// 1. RTM begin
Expand Down Expand Up @@ -1026,9 +1021,8 @@ void lbtree::del (key_type key)
b=1; t=p->num();
while (b+7<=t) {
m=(b+t) >>1;
r= key - p->k(m);
if (r>0) b=m+1;
else if (r<0) t = m-1;
if (key > p->k(m)) b=m+1;
else if (key < p->k(m)) t = m-1;
else {p=p->ch(m); ppos[i]=m; goto inner_done;}
}

Expand Down