This repository was archived by the owner on Oct 17, 2018. It is now read-only.
Fix style violations and shadowing of built in names#1
Open
kvlees wants to merge 2 commits into
Open
Conversation
Author
|
Ping for final review. Can you look at the "__core_actions_per_sec" function in overloadimpact/cli_tool/config_report.py - should the "exit" be removed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note, there were a few warning that I wasn't sure of the best fix. For example for warnings about variables not used - should I delete them or should they actually be used somewhere? So, it would be great if you could take a look at all my TODO statements and comment on the best fix. Then I can add the corrections to this pull request.