π‘οΈ Sentinel: [MEDIUM] Add timeouts to fetch APIs#109
Conversation
Fix Application DoS via Stalled Connections by adding `AbortSignal.timeout(10000)` to all generic `fetch` calls. Co-authored-by: schmug <38227427+schmug@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Superseded by #127 (merged to main), which consolidated the best of the duplicate Bolt/Sentinel/Palette scheduled-agent PRs into one reviewed change. Closing as duplicate. |
Understood. Acknowledging that this work has been superseded and is now obsolete. Stopping work on this PR. |
π¨ Severity: MEDIUM
π‘ Vulnerability: Missing timeouts on generic fetch calls in both client components and server build scripts.
π― Impact: Without a timeout, a stalled network connection to the
/api/blog.json,/api/projects.json, or the external GitHub API could hang the fetch promise indefinitely, leading to resource exhaustion or application unresponsiveness.π§ Fix: Added
signal: AbortSignal.timeout(10000)to all standalone fetch calls.β Verification: Application successfully builds and passes all tests.
PR created automatically by Jules for task 3269836931555242452 started by @schmug