Expand About bio with longer-form narrative (#11)#14
Open
schmug wants to merge 1 commit into
Open
Conversation
Move bio copy, current-focus items, tagline, and social links into a single shared module (src/data/about.ts) and render it identically on both About surfaces — the static /about page and the in-OS AboutApp. Bio expands to four paragraphs covering the studio-of-one framing, Cloudflare-native stack rationale, and CortechOS-as-metaphor note. Closes #11. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Deploying cortech-online with
|
| Latest commit: |
ba8cad7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://aa360f15.cortech-online.pages.dev |
| Branch Preview URL: | https://feature-about-bio-expand.cortech-online.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/data/about.tsso the static/aboutpage and the in-OSAboutApprender from one source./about.Closes #11.
Test plan
npm run typecheck— 0 errors, 0 warnings.npm teston new suite —src/data/about.test.ts4/4 (bio ≥ 4 non-empty paragraphs, current-focus fields populated, every social link https://).npm run test:e2e— 4/4 (existing desktop golden path + new/aboutstatic page spec asserting abio[0]prefix; About window spec also asserts the same prefix via the shared module)./aboutand the in-OS AboutApp side-by-side for layout parity after the brand-mark merge.Notes for reviewer
desktop golden pathfails on a cold Vite dev server with504 Outdated Optimize Depnoise (the test asserts zero console errors). Passes cleanly once the dev server is warm (e.g., one curl to/). Pre-existing, not regressed by this PR, but worth watching in CI.npm testrun at the repo root collects ~64 test files from.worktrees/brand-mark/node_modules/**becausevitest.config.tsexcludesnode_modules/**(top-level) rather than**/node_modules/**/.worktrees/**. One-line fix, deliberately out of scope here.🤖 Generated with Claude Code