Skip to content

πŸ›‘οΈ Sentinel: [Enhancement] Add timeout to GitHub API fetch call#78

Closed
schmug wants to merge 1 commit into
mainfrom
sentinel-github-api-timeout-4511906236845414184
Closed

πŸ›‘οΈ Sentinel: [Enhancement] Add timeout to GitHub API fetch call#78
schmug wants to merge 1 commit into
mainfrom
sentinel-github-api-timeout-4511906236845414184

Conversation

@schmug
Copy link
Copy Markdown
Owner

@schmug schmug commented May 1, 2026

πŸ›‘οΈ Sentinel: [Enhancement] Add timeout to GitHub API fetch call

Severity: Enhancement
Vulnerability: The prerendering build script (src/lib/github.ts) made a fetch call to the GitHub API without a timeout configured.
Impact: External HTTP requests that lack timeouts can cause the build process/pipeline to hang indefinitely if the third-party API becomes unresponsive or drops packets. This represents a build-time Denial of Service (DoS) vulnerability and can exhaust CI/CD compute resources.
Fix: Added signal: AbortSignal.timeout(10000) to the fetch call in src/lib/github.ts to ensure it fails fast securely rather than hanging. Added an explanatory comment. Recorded the learning in .jules/sentinel.md.
Verification: Ran pnpm test, pnpm lint, pnpm typecheck, and pnpm test:e2e to verify the application builds and tests pass successfully with the timeout configuration.


PR created automatically by Jules for task 4511906236845414184 started by @schmug

**Severity:** Enhancement
**Vulnerability:** The prerendering build script (`src/lib/github.ts`) made a `fetch` call to the GitHub API without a timeout configured.
**Impact:** External HTTP requests that lack timeouts can cause the build process/pipeline to hang indefinitely if the third-party API becomes unresponsive or drops packets. This represents a build-time Denial of Service (DoS) vulnerability and can exhaust CI/CD compute resources.
**Fix:** Added `signal: AbortSignal.timeout(10000)` to the `fetch` call in `src/lib/github.ts` to ensure it fails fast securely rather than hanging. Added an explanatory comment. Recorded the learning in `.jules/sentinel.md`.
**Verification:** Ran `pnpm test`, `pnpm lint`, `pnpm typecheck`, and `pnpm test:e2e` to verify the application builds and tests pass successfully with the timeout configuration.

Co-authored-by: schmug <38227427+schmug@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@schmug
Copy link
Copy Markdown
Owner Author

schmug commented May 16, 2026

Superseded by #127 (merged to main), which consolidated the best of the duplicate Bolt/Sentinel/Palette scheduled-agent PRs into one reviewed change. Closing as duplicate.

@schmug schmug closed this May 16, 2026
@google-labs-jules
Copy link
Copy Markdown
Contributor

Superseded by #127 (merged to main), which consolidated the best of the duplicate Bolt/Sentinel/Palette scheduled-agent PRs into one reviewed change. Closing as duplicate.

Understood. Acknowledging that this work is superseded by #127 and is now obsolete. Stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant