π‘οΈ Sentinel: [Enhancement] Add timeout to GitHub API fetch call#78
π‘οΈ Sentinel: [Enhancement] Add timeout to GitHub API fetch call#78schmug wants to merge 1 commit into
Conversation
**Severity:** Enhancement **Vulnerability:** The prerendering build script (`src/lib/github.ts`) made a `fetch` call to the GitHub API without a timeout configured. **Impact:** External HTTP requests that lack timeouts can cause the build process/pipeline to hang indefinitely if the third-party API becomes unresponsive or drops packets. This represents a build-time Denial of Service (DoS) vulnerability and can exhaust CI/CD compute resources. **Fix:** Added `signal: AbortSignal.timeout(10000)` to the `fetch` call in `src/lib/github.ts` to ensure it fails fast securely rather than hanging. Added an explanatory comment. Recorded the learning in `.jules/sentinel.md`. **Verification:** Ran `pnpm test`, `pnpm lint`, `pnpm typecheck`, and `pnpm test:e2e` to verify the application builds and tests pass successfully with the timeout configuration. Co-authored-by: schmug <38227427+schmug@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Superseded by #127 (merged to main), which consolidated the best of the duplicate Bolt/Sentinel/Palette scheduled-agent PRs into one reviewed change. Closing as duplicate. |
π‘οΈ Sentinel: [Enhancement] Add timeout to GitHub API fetch call
Severity: Enhancement
Vulnerability: The prerendering build script (
src/lib/github.ts) made afetchcall to the GitHub API without a timeout configured.Impact: External HTTP requests that lack timeouts can cause the build process/pipeline to hang indefinitely if the third-party API becomes unresponsive or drops packets. This represents a build-time Denial of Service (DoS) vulnerability and can exhaust CI/CD compute resources.
Fix: Added
signal: AbortSignal.timeout(10000)to thefetchcall insrc/lib/github.tsto ensure it fails fast securely rather than hanging. Added an explanatory comment. Recorded the learning in.jules/sentinel.md.Verification: Ran
pnpm test,pnpm lint,pnpm typecheck, andpnpm test:e2eto verify the application builds and tests pass successfully with the timeout configuration.PR created automatically by Jules for task 4511906236845414184 started by @schmug