feat: add /learn/security-txt and /learn/tls-rpt pages#366
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
dmarcheck | 1ce83bb | May 24 2026, 03:07 PM |
Closes #362. Adds RFC 9116 and RFC 8460 learn pages following the existing renderLearnX() pattern, wires both routes, adds both URLs to SITEMAP_URLS, updates the markdown hub, and adds smoke tests verifying 200 responses with correct canonicals and substantive content. https://claude.ai/code/session_01CnbNthXu35yeCa6PrvcVM2
schmug
force-pushed
the
claude/issue-362-learn-pages
branch
from
6b635d2 to
1ce83bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$(cat <<'EOF'
Summary
renderLearnSecurityTxt()andrenderLearnTlsRpt()tosrc/views/learn.ts, following the exactrenderLearnX()/learnPage()pattern — substantive RFC 9116 and RFC 8460 content covering record format, field semantics, common misconfigurations, and fix stepsGET /learn/security-txtandGET /learn/tls-rptroutes insrc/index.tsand adds both URLs toSTATIC_SITEMAP_URLS; updatesrenderLearnHubMarkdown()insrc/views/markdown.tswith both new slugsprotocolsarray driving the parametric loop tests intest/index.test.ts, plus dedicated content assertions (RFC references, key fields, canonical URL) and a sitemap assertionCloses #362
Test plan
GET /learn/security-txtreturns 200 with correct canonicalhttps://dmarc.mx/learn/security-txtGET /learn/tls-rptreturns 200 with correct canonicalhttps://dmarc.mx/learn/tls-rpt/checkCTA form and link to/scoring/sitemap.xmlnpm test— 1054 passed (1055 total; 1 pre-existing flaky network integration test)npm run typecheck— cleannpm run lint— clean, 135 files checkedhttps://claude.ai/code/session_01CnbNthXu35yeCa6PrvcVM2
EOF
)
Generated by Claude Code