chore(ci): switch CodeQL from default to advanced setup#370
Merged
Conversation
Adds .github/workflows/codeql.yml plus a config file at
.github/codeql/codeql-config.yml that excludes test/** from analysis.
Motivation: the js/incomplete-url-substring-sanitization rule was firing
on test assertions like expect(v.message.includes("example.com")) — no
URL flow, no fetch, no auth boundary, just a string match on asserted
output. Four such alerts have been dismissed as false positives; the
path-ignore config prevents the pattern from re-surfacing.
Cutover requires disabling default setup in repo Settings -> Code
security before this merges, otherwise advanced setup runs will error.
Job names match the previous "Analyze (<language>)" pattern so any
status-check pinning is preserved.
Actions are SHA-pinned per repo convention; Dependabot
(github-actions ecosystem) will keep them current.
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
dmarcheck | 7627d32 | May 24 2026, 01:55 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/codeql.yml(advanced setup) and.github/codeql/codeql-config.ymlexcludingtest/**from analysis.Why
The
js/incomplete-url-substring-sanitizationquery has been firing on test assertions likeexpect(v.message.includes("example.com")).toBe(true)— no URL flow, no fetch, no auth boundary, just.includes()on an asserted output string. Four such alerts (#8, #9, #12, #13) were dismissed as false positives on 2026-05-24; this PR prevents the pattern from re-surfacing on every test edit.Cutover sequence (read before merging)
mainand produces two checks namedAnalyze (actions)andAnalyze (javascript-typescript)— matching the previous default-setup job names so no branch-protection update is needed.If default setup is left enabled when this merges, the advanced workflow will error with "CodeQL analyses from advanced configurations cannot be processed when the default setup is enabled".
What's covered / not covered
actionsandjavascript-typescript(the latter covers both JS and TS in modern CodeQL — same coverage as before).main+ weekly cron (Mon 12:23 UTC).test/**and**/*.test.ts. Source code (includingmta-sts-worker/) still analyzed.Test plan
Analyze (actions)andAnalyze (javascript-typescript)checks run onmain.includes("example.com")assertion in a test file → confirm no CodeQL alert is raisedtest/**