Add gamerule for command units, expand lua API to interact wth gamerules #2219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ZombieFreak115
commented
Jan 23, 2026
ZombieFreak115
commented
- Adds gamerule for whether commanding puppet units is allowed, also adds another gamerule option for FoW, allowing only the observer tag to not have FoW.
- Add support for lua scripting for gamerules
- Fix the bug where it would always play the "ship select" sound when selecting units. Also change the shift-select behavoir slightly when selecting units to work like you would expect in Vic2 (Land units prioitized over naval units when nothing is selected, when land units are selected it will only select other land units and same for naval units).
- Apply Schombert's fix for the production directive popping up when resizing window.
- Move lua parsing to the very start of scenario creation, so that script triggers like gamerules can refer to them
- Create a new folder structure with a "Custom scipts" and "Game scripts" folder, in which it will parse every .lua file in each.
- When a user has the "Show all saves" option selected, try to load the save even if the checksum mismatches. The user will already have been warned of the possibility of a crash.
… so that it plays the correct sound, and shift-clicking works properly
…erence it. Add two folders to lua filesystem. Call the given lua function when a gamerule is changed
…file. Force-load the save if the user has the "show all saves" option enabled. Add map for gamerule options for faster retriving of gamerule ids for lua.
schombert
reviewed
Jan 24, 2026
|
|
||
| - `alice_can_goto_war_against_spherelord_default_setting = 1.0f` - Sets the default setting for the hardcoded gamerule deciding whether a sphereling can goto war against its spherelord. Can be either 1 (which means they can declare war against spherelord), or 0 (which means they cannot). Default is 1 | ||
| - `alice_allow_partial_retreat_default_setting = 0.0f` - Sets the default setting for the hardcoded gamerule deciding whether armies can partial-retreat from battles. 1.0 means it is enabled, while 0 means it is disabled. | ||
| - `alice_allow_partial_retreat_default_setting = 0.0f` - Sets the default setting for the hardcoded gamerule deciding whether armies can partial-retreat from battles. 1.0 means it is enabled, 0 means it is disabled, and 2.0 it is disabled only for the observer tag |
Owner
There was a problem hiding this comment.
what exactly does that mean? Could the observer tag normally control armies?
Contributor
Author
There was a problem hiding this comment.
That should be on the new oberver-option for toggling fog of war, i will change it next PR to be in the proper place
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.