Conversation
|
To view this pull requests documentation preview, visit the following URL: Documentation is deployed and generated using docs.page. |
Package Version ReportThe following packages have been updated: |
a29793c to
9a642c7
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #702 +/- ##
==========================================
- Coverage 60.01% 59.96% -0.05%
==========================================
Files 194 194
Lines 10915 10924 +9
==========================================
Hits 6551 6551
- Misses 4364 4373 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Refactored jaspr_serverpod to follow upstream PR schultek#702 approach: - Remove explicit Relic dependency (handled internally by Serverpod 3.0) - Delete shelf_relic_adapter.dart (95 lines) - use inline conversion - Update JasprRoute to use serverpod.Request instead of relic.Request - Add HijackException handling for WebSocket support - Simplify Response creation with direct Serverpod types - Update version to 0.7.0 BREAKING CHANGES: - JasprRoute.build() now takes serverpod.Request (not relic.Request) - Must hide Request, Response, Handler from jaspr/server.dart import - Route path changed from /* to /** - Removed toShelfRequest/toRelicResponse adapters Migration: - Update imports: hide Request, Response, Handler from jaspr/server - Import serverpod types from package:serverpod/serverpod.dart - Update dependent packages to jaspr_serverpod ^0.7.0 - Remove explicit relic dependency 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 (1M context) <noreply@anthropic.com>
9a642c7 to
5de14d2
Compare
|
I would love to see this merged. I would like to to use jaspr on our serverpod 3 app at some point. There's a very simple ./pubspec.lock conflict: dart_style's version became 3.1.3 in main. Other than that I think this needs a review. |
|
@schultek , do you have any idea when this will be merged and shipped ? |
|
@kivocsa99 I'm waiting for a review from the serverpod team for this PR |
|
I've asked Viktor if anyone of his team could have a look. Can I help resolving the current conflicts? |
Refactored jaspr_serverpod to follow upstream PR schultek#702 approach: - Remove explicit Relic dependency (handled internally by Serverpod 3.0) - Delete shelf_relic_adapter.dart (95 lines) - use inline conversion - Update JasprRoute to use serverpod.Request instead of relic.Request - Add HijackException handling for WebSocket support - Simplify Response creation with direct Serverpod types - Update version to 0.7.0 BREAKING CHANGES: - JasprRoute.build() now takes serverpod.Request (not relic.Request) - Must hide Request, Response, Handler from jaspr/server.dart import - Route path changed from /* to /** - Removed toShelfRequest/toRelicResponse adapters Migration: - Update imports: hide Request, Response, Handler from jaspr/server - Import serverpod types from package:serverpod/serverpod.dart - Update dependent packages to jaspr_serverpod ^0.7.0 - Remove explicit relic dependency 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 (1M context) <noreply@anthropic.com>
Description
Resolves #701
Type of Change
Ready Checklist
the semantic_changelog format.
///).