Image Source/Sink Support#77
Merged
karls-science merged 3 commits intomainfrom Apr 28, 2026
Merged
Conversation
Contributor
|
I probably would have named the node |
Display peripherals should be handled by user-defined ApplicationNode logic rather than a dedicated Synapse sink node.
Contributor
Author
|
Renamed |
calvinleng-science
requested changes
Apr 22, 2026
|
Yeah I guess that makes sense to keep things consistent for now- but imo its a little ugly to have two timestamps, in theory a client could compute timestamp_ns by doing the unix_timestamp[0]+sampling_rate*i calculation itself. |
calvinleng-science
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add support for ImageSource and ImageSink nodes to enable prima as a synapse server.
Changes
Testing
How can this change be tested?
See unit tests in below link
Please provide a link to a reference server and client implementation in synapse-python.
sciencecorp/synapse-python#173