Feature: Tap API in simulated broadband source#141
Merged
gilbert-sci merged 6 commits intosciencecorp:mainfrom Aug 5, 2025
Merged
Feature: Tap API in simulated broadband source#141gilbert-sci merged 6 commits intosciencecorp:mainfrom
gilbert-sci merged 6 commits intosciencecorp:mainfrom
Conversation
Contributor
Author
|
@namthor9 tagging as I can't seem to be able to add a reviewer. |
Contributor
|
@arminvoid -- thanks for your interest. There are a few things we need to set up before we can actually accept community contributions, but it's probably time. @morninj @gilbert-sci |
Collaborator
|
Hi @arminvoid—can you please sign our Contributor License Agreement? |
Contributor
Author
|
hey @morninj it's signed now. thanks! |
gilbert-sci
suggested changes
Jul 25, 2025
Contributor
gilbert-sci
left a comment
There was a problem hiding this comment.
Thank you for the contribution, mostly just nits.
arminvoid
commented
Jul 28, 2025
Contributor
Author
arminvoid
left a comment
There was a problem hiding this comment.
@gilbert-sci thanks for the review. i have made the required changes.
gilbert-sci
approved these changes
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a change for #125. I wasn't sure if there's another simulated/virtual SciFi device that I should write the example against so I went ahead and updated the simulated broadband source in this repo to stream data over tap API. Also migrates legacy ndtp type to BroadbandFrame.
Testing
Run simulated device
Run Client