Skip to content

refactor: add setup.sh en lieu of Makefile#68

Merged
antoniaelsen merged 6 commits intomainfrom
refactor/setup
Apr 8, 2025
Merged

refactor: add setup.sh en lieu of Makefile#68
antoniaelsen merged 6 commits intomainfrom
refactor/setup

Conversation

@antoniaelsen
Copy link
Copy Markdown
Contributor

@antoniaelsen antoniaelsen commented Mar 1, 2025

for Windows support

tested on Windows, OSX

@antoniaelsen antoniaelsen requested a review from gilbert-sci March 1, 2025 04:22
@antoniaelsen antoniaelsen marked this pull request as ready for review March 5, 2025 08:26
@antoniaelsen antoniaelsen linked an issue Mar 5, 2025 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

@gilbert-sci gilbert-sci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly just an update to the docs

Comment thread Makefile Outdated
test:
pytest -v No newline at end of file
./setup.sh test

No newline at end of file
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit newline

Comment thread setup.sh
generate
;;
*)
echo "Usage: $0 {clean|generate|test|all}"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this generate helper doesn't take arguments anymore.

Comment thread setup.sh Outdated
Comment thread Makefile Outdated
Comment thread Makefile Outdated
@antoniaelsen antoniaelsen merged commit 4e71601 into main Apr 8, 2025
2 checks passed
@antoniaelsen antoniaelsen deleted the refactor/setup branch April 8, 2025 00:05
antoniaelsen added a commit that referenced this pull request Apr 8, 2025
…e) (#68)

* build: remove Makefile, add setup.sh

* chore: lint

* chore: update setup.sh

* chore: update Makefile

* chore: update Makefile

* chore: update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate to shell script from Makefile for Windows support

2 participants