Fix streaming getting stuck with no socket timeout (#92)#96
Merged
polymerizedsage merged 2 commits intomainfrom Apr 7, 2025
Merged
Fix streaming getting stuck with no socket timeout (#92)#96polymerizedsage merged 2 commits intomainfrom
polymerizedsage merged 2 commits intomainfrom
Conversation
antoniaelsen
reviewed
Apr 1, 2025
antoniaelsen
reviewed
Apr 1, 2025
Contributor
antoniaelsen
left a comment
antoniaelsen
left a comment
There was a problem hiding this comment.
tested with sim devices as well, lgtm. would 1sec ever be too short for laggy connections?
gilbert-sci
reviewed
Apr 1, 2025
| try: | ||
| data, _ = self.__socket.recvfrom(8192) | ||
| bytes_read = len(data) | ||
| except socket.timeout: |
Contributor
There was a problem hiding this comment.
We could try to reconnect and read again here?
Contributor
Author
There was a problem hiding this comment.
like try to receive from the socket again? I don't quite understand why would try again after timing out. Shouldn't it be up to the caller to decide if they want to re-try the read?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #92 by adding a timeout to socket recv operations for the StreamOut node. When the socket stops sending data the CLI will show an error that it failed to get data from the socket. Tested with SciFi.