Disallow duplicate entries in categorical axes #660
Open
Rachit931 wants to merge 14 commits intoscikit-hep:mainfrom
Open
Disallow duplicate entries in categorical axes #660Rachit931 wants to merge 14 commits intoscikit-hep:mainfrom
Rachit931 wants to merge 14 commits intoscikit-hep:mainfrom
Conversation
Contributor
Author
|
I rebased on main to resolve the merge conflict caused by the recent image update in the upstream so that CI could run. No other functional changes were made |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR disallows duplicate entries in categorical axes by validating inputs at axis construction time.
Duplicate categorical entries currently lead to ambiguous indexing behavior. This change raises a
ValueErrorwhen duplicate categories are provided, preventing such axes from being created.Tests are added to cover both string and integer categorical axes.
Closes : #644