Refactor KMedoids#140
Draft
chkoar wants to merge 9 commits into
Draft
Conversation
adrinjalali
reviewed
Apr 14, 2022
Member
adrinjalali
left a comment
adrinjalali
left a comment
There was a problem hiding this comment.
So, the tests in the private methods are failing. What should we do?
That's quite normal. We should be testing everything in the library, and sometimes it's easier to test smaller parts of the code which sometimes happen to be private.
| - id: trailing-whitespace | ||
| - repo: https://github.com/psf/black | ||
| rev: 20.8b1 | ||
| rev: 22.3.0 |
Member
There was a problem hiding this comment.
thanks for this change, but it should be a separate PR :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to reduce the cyclomatic complexity in k medoids.
During refactoring I realized that we are testing private methods. Why is that?
So, the tests in the private methods are failing. What should we do?
Make the methods public, document and test them or just remove the tests by replace them with behavior testing on public methods?
I think that tests could be improved in general.