Fix(SCIMMY.Messages.ListResponse): handle startIndex exceeding total resources#102
Open
morzzz007 wants to merge 1 commit intoscimmyjs:mainfrom
Open
Fix(SCIMMY.Messages.ListResponse): handle startIndex exceeding total resources#102morzzz007 wants to merge 1 commit intoscimmyjs:mainfrom
morzzz007 wants to merge 1 commit intoscimmyjs:mainfrom
Conversation
…resources Per SCIM RFC 7644, when startIndex is beyond the total number of results, the response should return an empty Resources array while preserving the correct totalResults value. Added logic to detect this case and return an empty array when startIndex exceeds the complete (non-pre-paginated) result set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug in
SCIMMY.Messages.ListResponsewhere pagination returns incorrect results whenstartIndexexceeds the total number of resources.Per SCIM RFC 7644, when
startIndexis beyond the total results, the response should return an emptyResourcesarray while preserving the correcttotalResultsvalue.Changes
startIndexexceeds the complete (non-pre-paginated) result setResourcesarray while maintaining correct metadata