Skip to content

Include output title in correlation plot axis labels#765

Merged
SimonHeybrock merged 3 commits intomainfrom
757-correlation-plot-missing-output-info
Mar 6, 2026
Merged

Include output title in correlation plot axis labels#765
SimonHeybrock merged 3 commits intomainfrom
757-correlation-plot-missing-output-info

Conversation

@SimonHeybrock
Copy link
Member

@SimonHeybrock SimonHeybrock commented Mar 5, 2026

Summary

  • For multi-output workflows, correlation plot axis labels and the wizard's "Histogram Bins" fields now include the output title (e.g., "Cave Monitor (Delta)" instead of just "Cave Monitor")
  • Axis titles are resolved at plotter creation time in the orchestrator, ensuring correctness for configs loaded from persistence or templates — not just the wizard flow

Motivation

Fixes #757 — the correlation plot wizard and rendered axis labels were missing the output title, making it ambiguous which output a given axis referred to when the workflow produces multiple outputs.

Test plan

  • Unit tests for resolve_axis_source_titles / inject_axis_source_titles (single-output, multi-output, both axes, dict/model params)
  • End-to-end test verifying the HoloViews kdim label matches x_axis_source with output title
  • Manual: create a correlation plot from a multi-output workflow — verify step 3 "Histogram Bins" and the plot X-axis both show the output title
  • Manual: reload from persisted config — verify X-axis still includes the output title. NOTE: decided to not support legacy config. Old plots still load, but need to recreate plots to get full name!

🤖 Generated with Claude Code

For multi-output workflows, the axis source title now includes the
output title (e.g., "Cave Monitor (Delta)" instead of "Cave Monitor")
in both the wizard modal and the rendered plot axis labels.

Axis title resolution is applied at plotter creation time in the
orchestrator, ensuring correctness for configs loaded from persistence
or templates, not just the wizard flow.

Closes #757
The modal already bakes the correct output title into x_axis_source /
y_axis_source when creating or editing correlation histogram configs.
The orchestrator does not need to duplicate this logic at plotter
creation time.
@SimonHeybrock SimonHeybrock marked this pull request as ready for review March 5, 2026 13:47
@SimonHeybrock SimonHeybrock enabled auto-merge March 5, 2026 13:47
When a workflow has multiple outputs, append the output title to the
source title in correlation histogram axis labels to disambiguate
(e.g. "Cave Monitor (Delta)"). Single-output workflows are unchanged.
@SimonHeybrock
Copy link
Member Author

LGTM

@SimonHeybrock SimonHeybrock disabled auto-merge March 6, 2026 08:13
@SimonHeybrock SimonHeybrock merged commit 2f61b11 into main Mar 6, 2026
10 of 12 checks passed
@SimonHeybrock SimonHeybrock deleted the 757-correlation-plot-missing-output-info branch March 6, 2026 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Correlation plot: Histogram Bins and X-axis does not show output name/title

1 participant