Open
Conversation
nvaytet
reviewed
Mar 6, 2026
| import warnings | ||
| from typing import Literal | ||
|
|
||
| import ipywidgets |
Member
There was a problem hiding this comment.
Can you abbreviate ipywidgets to ipw?
That's what we do everywhere else in the code.
| @@ -154,12 +155,6 @@ def _get_points_info(artist, figure): | |||
|
|
|||
|
|
|||
| def _make_points(**kwargs): | |||
Member
There was a problem hiding this comment.
Hmm, does this mean that we can do away with the entire function _make_points (and the like)?
The comment clearly states it's to avoid issues with dependency import?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since lazy_loader was introduced in #405, modules are lazily loaded so deferred imports to avoid hard dependencies are no longer needed.
Closes #541
Did some rudimentary tests on import times, didn't see much affect as expected.