Use setuptools_scm while building docs in conda env#684
Conversation
|
Docs CI builds with the correct version number: |
This reverts commit bb2381c.
There was a problem hiding this comment.
I'm surprised this is required because we list setuptools_scm in the build requirements. So when we call pip install --no-deps, does that not even install build requirements?
There was a problem hiding this comment.
https://pip.pypa.io/en/latest/cli/pip_install/#cmdoption-no-build-isolation
It disables built deps
There was a problem hiding this comment.
Did you check a release build? We have some logic in CI that installs scippneutron from conda in some cases. Does it get the correct version then?
There was a problem hiding this comment.
Why do we even have that logic? The release action also triggers the same pip install --no-build-isolation --no-deps -e . step, there is no version passed in manually. setuptools_scm picks it from the tag.
I tried to manually trigger the logic for fetching scippneutron from conda-forge https://github.com/scipp/scippneutron/actions/runs/22759040133/job/66010787060, and the docs look okay too https://remote-unzip.deno.dev/scipp/scippneutron/artifacts/5795735768/
But I'm not sure where we are using this unless explicitly trigged by a workflow_dispatch.
Maybe it got lost in the many translations?
There was a problem hiding this comment.
It might be a left over from when we rebuilt the docs for the previous version on release to insert a banner linking to the latest version. My guess is that we no longer need it.
This should fix #681
From the doc building logs:
This is happening as there is no
setuptools_scmin the conda env.