Skip to content

Add SCITOKENS_SKIP_ONLINE_TESTS env var to disable network-dependent tests #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Add SCITOKENS_SKIP_ONLINE_TESTS env var to disable network-dependent tests #207

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7fc06ec
Initial plan
Copilot Mar 7, 2026
23507d2
Add SCITOKENS_SKIP_ONLINE_TESTS env var to skip network-dependent tests
Copilot Mar 7, 2026
b6d22a0
Apply suggestions from code review
djw8605 Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions test/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -679,6 +679,10 @@ class KeycacheTest : public ::testing::Test {
};

TEST_F(KeycacheTest, RefreshTest) {
if (std::getenv("SCITOKENS_SKIP_ONLINE_TESTS")) {
GTEST_SKIP() << "Skipping online test (SCITOKENS_SKIP_ONLINE_TESTS is "
"set)";
}
Comment on lines +682 to +685
char *err_msg = nullptr;
auto rv = keycache_refresh_jwks(demo_scitokens_url.c_str(), &err_msg);
ASSERT_TRUE(rv == 0) << err_msg;
Expand All @@ -695,6 +699,10 @@ TEST_F(KeycacheTest, RefreshTest) {
}

TEST_F(KeycacheTest, RefreshInvalid) {
if (std::getenv("SCITOKENS_SKIP_ONLINE_TESTS")) {
GTEST_SKIP() << "Skipping online test (SCITOKENS_SKIP_ONLINE_TESTS is "
"set)";
}
char *err_msg = nullptr, *jwks;
auto rv =
keycache_refresh_jwks("https://demo.scitokens.org/invalid", &err_msg);
Expand Down Expand Up @@ -888,6 +896,10 @@ TEST_F(KeycacheTest, SetInvalidExpirationTest) {
}

TEST_F(KeycacheTest, RefreshExpiredTest) {
if (std::getenv("SCITOKENS_SKIP_ONLINE_TESTS")) {
GTEST_SKIP() << "Skipping online test (SCITOKENS_SKIP_ONLINE_TESTS is "
"set)";
}
char *err_msg = nullptr, *jwks;
int new_expiration_interval = 0;
std::string key = "keycache.expiration_interval_s";
Expand All @@ -910,6 +922,10 @@ TEST_F(KeycacheTest, RefreshExpiredTest) {
}

TEST_F(KeycacheTest, NegativeCacheTest) {
if (std::getenv("SCITOKENS_SKIP_ONLINE_TESTS")) {
GTEST_SKIP() << "Skipping online test (SCITOKENS_SKIP_ONLINE_TESTS is "
"set)";
}
// This test verifies that failed issuer lookups are cached as negative
// entries and that subsequent attempts fail quickly with the right counter
char *err_msg = nullptr;
Expand Down Expand Up @@ -1058,6 +1074,10 @@ TEST_F(KeycacheTest, LoadJwksTest) {
}

TEST_F(KeycacheTest, LoadJwksMissingTest) {
if (std::getenv("SCITOKENS_SKIP_ONLINE_TESTS")) {
GTEST_SKIP() << "Skipping online test (SCITOKENS_SKIP_ONLINE_TESTS is "
"set)";
}
// Test load API with missing issuer - should attempt refresh
char *err_msg = nullptr;
char *jwks = nullptr;
Expand All @@ -1071,6 +1091,10 @@ TEST_F(KeycacheTest, LoadJwksMissingTest) {
}

TEST_F(KeycacheTest, LoadJwksTriggersRefreshWhenStale) {
if (std::getenv("SCITOKENS_SKIP_ONLINE_TESTS")) {
GTEST_SKIP() << "Skipping online test (SCITOKENS_SKIP_ONLINE_TESTS is "
"set)";
}
// Force next_update in the past so load_jwks triggers a refresh
char *err_msg = nullptr;

Expand Down
Loading