Skip to content

CI/CD Fixes#3

Merged
dbotwinick merged 5 commits intomainfrom
develop
Apr 2, 2026
Merged

CI/CD Fixes#3
dbotwinick merged 5 commits intomainfrom
develop

Conversation

@dbotwinick
Copy link
Copy Markdown
Contributor

This pull request introduces several improvements and additions across the Python and TypeScript codebases, focusing on CI workflow enhancements, code quality configuration, and API code cleanup. The most notable changes include adding a build step for the TypeScript SDK in the CI pipeline, updating Python linting rules, and refactoring the associations API for readability and maintainability.

CI/CD Workflow Improvements:

  • Added a dedicated build-typescript-sdk job to the GitHub Actions workflow, ensuring the TypeScript SDK is built and its artifacts are uploaded before running dependent tests. The test-typescript job now depends on this build step and downloads the artifacts. Node.js version is updated to 22, and npm ci replaces npm install for more reliable dependency installs. [1] [2]
  • Removed Python and Node.js dependency caching from the CI workflow for both memorylayer-core-python and memorylayer-sdk-python jobs. [1] [2]
  • Modified test commands to use the -x flag in both Python and TypeScript jobs, causing test runs to stop after the first failure, which can speed up feedback during CI. [1] [2]

Python Code Quality and Linting:

  • Updated the pyproject.toml configuration for Ruff to ignore several additional linting rules, aligning linting with project conventions and intentional code patterns (e.g., long lines, unused variables, specific naming).

API Code Cleanup and Refactoring:

  • Refactored memorylayer_server/api/v1/associations.py for improved readability: reordered imports, consolidated logger and exception handling statements, and streamlined audit logging. Also improved error handling and authorization checks for association endpoints. [1] [2] [3] [4] [5] [6] [7]
  • Minor code style and typing improvements in API files, such as switching to modern type hints, standardizing string quoting, and cleaning up function signatures in api/health.py and api/__init__.py. [1] [2] [3] [4] [5]

TypeScript Dependency Management:

  • Added a new package-lock.json for the memorylayer-cc-plugin, defining dependencies and development requirements for the plugin and its local packages.

@dbotwinick dbotwinick merged commit 0f76fd9 into main Apr 2, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant