Merged
Conversation
… quotes and improving import organization across multiple files.
…e API request structure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and additions across the Python and TypeScript codebases, focusing on CI workflow enhancements, code quality configuration, and API code cleanup. The most notable changes include adding a build step for the TypeScript SDK in the CI pipeline, updating Python linting rules, and refactoring the associations API for readability and maintainability.
CI/CD Workflow Improvements:
build-typescript-sdkjob to the GitHub Actions workflow, ensuring the TypeScript SDK is built and its artifacts are uploaded before running dependent tests. Thetest-typescriptjob now depends on this build step and downloads the artifacts. Node.js version is updated to 22, andnpm cireplacesnpm installfor more reliable dependency installs. [1] [2]memorylayer-core-pythonandmemorylayer-sdk-pythonjobs. [1] [2]-xflag in both Python and TypeScript jobs, causing test runs to stop after the first failure, which can speed up feedback during CI. [1] [2]Python Code Quality and Linting:
pyproject.tomlconfiguration for Ruff to ignore several additional linting rules, aligning linting with project conventions and intentional code patterns (e.g., long lines, unused variables, specific naming).API Code Cleanup and Refactoring:
memorylayer_server/api/v1/associations.pyfor improved readability: reordered imports, consolidated logger and exception handling statements, and streamlined audit logging. Also improved error handling and authorization checks for association endpoints. [1] [2] [3] [4] [5] [6] [7]api/health.pyandapi/__init__.py. [1] [2] [3] [4] [5]TypeScript Dependency Management:
package-lock.jsonfor thememorylayer-cc-plugin, defining dependencies and development requirements for the plugin and its local packages.