Skip to content

[WIP] [test for ai] Swapped the fedora base of the 1.24 container from fedora 38 to the latest version of the container #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PavolSloboda wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP] [test for ai] Swapped the fedora base of the 1.24 container from fedora 38 to the latest version of the container #367

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion 1.24/Dockerfile.fedora
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM quay.io/fedora/s2i-core:38
FROM quay.io/fedora/s2i-core:latest
Copy link

@coderabbitai coderabbitai bot Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Find all Dockerfiles in the repository and check their Fedora base versions
echo "=== All Dockerfiles in repository ==="
find . -type f \( -name "Dockerfile*" -o -name "*.fedora" \) | head -20

echo ""
echo "=== Checking current file and nearby context ==="
if [ -f "1.24/Dockerfile.fedora" ]; then
  head -20 "1.24/Dockerfile.fedora"
fi

echo ""
echo "=== Looking for other Fedora version references in Dockerfiles ==="
rg "FROM quay.io/fedora" --glob "Dockerfile*" --glob "*.fedora" -n

Repository: sclorg/nginx-container

Length of output: 1576

🌐 Web query:

Fedora s2i-core available versions 2026

💡 Result:

In Fedora, the S2I CLI is packaged as source-to-image (there isn’t a Fedora RPM named s2i-core; “s2i-core” is commonly used for container base images). On Fedora in 2026 (as shown in current Fedora package repos), the available source-to-image versions are: (packages.fedoraproject.org)

Fedora release Stable package version
Rawhide 1.5.1-3.fc44
Fedora 44 1.5.1-3.fc44
Fedora 43 1.5.1-1.fc43
Fedora 42 1.5.1-1.fc42

If you meant the s2i-core container image, Fedora’s “Apps/Stacks” community images (including base images like s2i-core) are published under the quay.io/fedora org (moved there from the older locations). (fedoramagazine.org)

Citations:

Avoid using the :latest tag—pin to a specific Fedora version.

Using :latest breaks build reproducibility: successive builds may pull different Fedora versions, leading to inconsistent behavior and harder debugging. Additionally, this is the only Dockerfile in the repository using :latest; all others pin to specific versions (1.20 and 1.22 use :37, 1.26 uses :40). For consistency and reliability, pin to a specific version like :40 or :42.

Proposed fix 
-FROM quay.io/fedora/s2i-core:latest
+FROM quay.io/fedora/s2i-core:40
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
FROM quay.io/fedora/s2i-core:latest
FROM quay.io/fedora/s2i-core:40
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@1.24/Dockerfile.fedora` at line 1, The base image in the Dockerfile currently
uses the floating tag "quay.io/fedora/s2i-core:latest"; change the FROM line in
the Dockerfile to pin to a specific Fedora version (e.g.,
"quay.io/fedora/s2i-core:40" or "quay.io/fedora/s2i-core:42") to ensure
reproducible builds and consistency with other Dockerfiles (see tags used in
1.20/1.22/1.26). Update the single FROM instruction accordingly and commit the
Dockerfile change.


# nginx 1.24 image.
#
Expand Down