Closed
Conversation
Pull Request validationFailed🔴 Review - Missing review from a member (1 required) Success🟢 CI - All checks have passed |
Contributor
Author
|
[test-pytest][test-openshift] |
Testing Farm results
|
Merged
jackorp
force-pushed
the
ruby-4.0
branch
2 times, most recently
from
bfb1534 to
393f8b0
Compare
Contributor
Author
|
[test-pytest][test-openshift] |
Contributor
Author
|
[test-pytest][test-openshift] |
Contributor
Author
|
[test-pytest][test-openshift] |
Contributor
Author
|
[test-pytest][test-openshift] |
The binaries in demodularized rubies were suffixed with the MAJOR.MINOR versioning. In these containers, provide the unversioned commands via a symlink.
With Bundler >= 4.0, the CLI no longer accepts config options as part of CLI. Set the path to a custom directory in a local directory with `bundle config set --local path <path>` where applicable.
Delete the 2.5/test/examples symlink and add Ruby 2.5 specific files where necessary. This change is necessary as there is increased difficulty in code sharing between 4.0 and 2.5. Here the change was prompted by bundler's CLI incompatibilities. Bundler 4 removed ability to specify configuration options, such as `--path` with some commands such as `install`. Options have to be set throught `bundle config` CLI. However between bundler 1.16 in Ruby 2.5 and Bundler 4 in Ruby 4.0 there are differences in the CLI API, where it is not possible to share the same set of commands easily and achieve the same effect. Attempt to set the path via `bundle config set` in Ruby 2.5 container will produce bogus value in `./.bundle/config` that can result in undesired install behavior. And in Bundler 4, using `bundle config` without `set` `get`, ... is deprecated. Instead of trying to keep the compatibility between versions at all cost, the offending Dockerfile was replaced by actual file, the rest of the directory was symlinked per-item to retain code sharing where reasonable.
Contributor
Author
|
Tests should be viewed in dedicated PR #628 that focuses on updating them for Ruby 4.0. |
Contributor
Author
|
integrated in #628 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.