Skip to content

Call daily_scl_tests from new directory#95

Merged
phracek merged 1 commit intomainfrom
call_daily_test_from_new_directory
Mar 13, 2026
Merged

Call daily_scl_tests from new directory#95
phracek merged 1 commit intomainfrom
call_daily_test_from_new_directory

Conversation

@phracek
Copy link
Member

@phracek phracek commented Mar 13, 2026

This bug was introduced by sclorg/ci-scripts#223

Summary by CodeRabbit

  • Tests
    • Updated nightly test plan configurations to reflect test script location changes across multiple test environments.

Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@coderabbitai
Copy link

coderabbitai bot commented Mar 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2e25d0ff-9a72-42e6-bef7-ee3258a5aeb1

📥 Commits

Reviewing files that changed from the base of the PR and between d1dd360 and 9f23be3.

📒 Files selected for processing (3)
  • plans/nightly/nightly-c10s.fmf
  • plans/nightly/nightly-c9s.fmf
  • plans/nightly/nightly-fedora.fmf

📝 Walkthrough

Walkthrough

Three nightly test plan files updated to reference a test script at a deeper directory path. The test invocation endpoint changed from ./daily_tests/daily_scl_tests.sh to ./daily-tests/daily_tests/daily_scl_tests.sh across all nightly plans.

Changes

Cohort / File(s) Summary
Nightly Test Plan Paths
plans/nightly/nightly-c10s.fmf, plans/nightly/nightly-c9s.fmf, plans/nightly/nightly-fedora.fmf
Updated test script invocation path from ./daily_tests/daily_scl_tests.sh to ./daily-tests/daily_tests/daily_scl_tests.sh to reflect new directory structure.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Paths shift and dance through nested trees,
Scripts find new homes with gentle ease,
From shallow roots to depths below,
Our nightly tests continue to glow!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: updating the path to call daily_scl_tests from a new directory structure across all three nightly test plan files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch call_daily_test_from_new_directory
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@phracek phracek merged commit e901753 into main Mar 13, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant