Open
Conversation
|
This header has "only" been deprecated since Boost 1.50 (though I'd guess it got deprecated as part of the move to Filesystem V3 which happened earlier than that, it's just that V2 was kept around for a while for compatibility). Even though that version is about 12 years old, ElectricSheep still lists the even older 1.39 as the minimum version, so this change should probably either bump the minimum version, or conditionally change which includes are used based on the version of Boost in use |
Contributor
|
I think we shouldn't bump the minimum version, as this would break compilation for many older systems. After all boost 1.85 is only a few months old. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.