Skip to content

Python 3 Compatibility#8

Open
RobLoach wants to merge 2 commits into
scottrice:masterfrom
RobLoach:python3
Open

Python 3 Compatibility#8
RobLoach wants to merge 2 commits into
scottrice:masterfrom
RobLoach:python3

Conversation

@RobLoach

Copy link
Copy Markdown

Allows running in both Python 2 and 3. Requires more testing.

@scottrice

Copy link
Copy Markdown
Owner

Awesome! This is something thats come up in the past, and I would love to make this happen.

I'll try to take a look sometime soon, but I appreciate you doing this.

@RobLoach

RobLoach commented Feb 3, 2016

Copy link
Copy Markdown
Author

Have to run through testing and make sure it's still functional.

@vgonisanz

Copy link
Copy Markdown

+1

@RobLoach

Copy link
Copy Markdown
Author

Might be good to just move entirely to Python 3.

@vgonisanz

Copy link
Copy Markdown

I found this pull request while updating Ice repository to python 3 using 2to3, using this repository with @RobLoach changes. For now is not working but if I get it I will tell you something.

@vgonisanz

vgonisanz commented Jan 12, 2017

Copy link
Copy Markdown

When you change
match = re.match(ur
for
match = re.match(u
The unit test start failing, result is:

Ran 59 tests in 2.794s

FAILED (failures=3, errors=28)

I run them at main path using:
python -m unittest discover tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants