docs: Documenting built-in mixins#232
Draft
rennerocha wants to merge 12 commits intoscrapinghub:masterfrom
rennerocha:mixins_docs
Draft
docs: Documenting built-in mixins#232rennerocha wants to merge 12 commits intoscrapinghub:masterfrom rennerocha:mixins_docs
rennerocha wants to merge 12 commits intoscrapinghub:masterfrom
rennerocha:mixins_docs
Conversation
|
Hey @rennerocha I've looking a bit into #133 and this and was wondering if the issue could be up for grabs? I think documenting SpiderMonitorMixin should include some docs for I'd be happy to contribute some docs to this. |
Codecov Report
@@ Coverage Diff @@
## master #232 +/- ##
=======================================
Coverage 69.28% 69.28%
=======================================
Files 67 67
Lines 2745 2745
Branches 306 306
=======================================
Hits 1902 1902
Misses 784 784
Partials 59 59Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continue work started on #133