Fix/473 process item missing spider arg#474
Open
iayanpahwa wants to merge 3 commits intoscrapinghub:masterfrom
Open
Fix/473 process item missing spider arg#474iayanpahwa wants to merge 3 commits intoscrapinghub:masterfrom
iayanpahwa wants to merge 3 commits intoscrapinghub:masterfrom
Conversation
Scrapy 2.14+ inspects process_item() parameter names to decide whether to pass the spider argument. Rename _ to spider=None so it works with both old and new Scrapy versions. (scrapinghub#473)
Verifies that ItemValidationPipeline.process_item() works when called without the spider argument, as Scrapy 2.14+ does. (scrapinghub#473)
iayanpahwa
force-pushed
the
fix/473-process-item-missing-spider-arg
branch
from
76ea943 to
d458b77
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #474 +/- ##
=======================================
Coverage 79.95% 79.95%
=======================================
Files 77 77
Lines 3287 3287
Branches 323 323
=======================================
Hits 2628 2628
Misses 591 591
Partials 68 68 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_tospider=Noneinprocess_item()so Scrapy 2.14+ correctly detects the parameter and the method works with or without the spider argumentprocess_item()without spider argumentFixes #473