Add reactorless support - #311
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #311 +/- ##
==========================================
- Coverage 98.02% 97.96% -0.06%
==========================================
Files 15 15
Lines 2375 2404 +29
Branches 432 439 +7
==========================================
+ Hits 2328 2355 +27
- Misses 20 21 +1
- Partials 27 28 +1
🚀 New features to boost your workflow:
|
AdrianAtZyte
marked this pull request as ready for review
July 24, 2026 09:26
AdrianAtZyte
commented
Jul 24, 2026
| # The default Twisted-based HTTP/1.1 handler cannot be used without a | ||
| # reactor; fall back to the asyncio-based httpx handler instead. | ||
| default = ( | ||
| "scrapy.core.downloader.handlers.http11.HTTP11DownloadHandler" |
Contributor
Author
There was a problem hiding this comment.
@wRAR: You were right, it was hard-coded.
wRAR
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #310.