Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #12
Created a new
device_config.jsonconfiguration file.Format is as follows.
{ "MODEL_KEY": { "display_name": "string", "description": "string", "implementation_id": "string", "implementation_configuration": { "this": "is unique per implementation" }, "available_features": {} } }implementation_idis unique for each model implementation.model_implementations/import_model_implementation.pycontains the mappings fromimplementation_idto model implementation.TranscriptionModelBaserequires a new methodvalidate_config()that is used to validate if configuration object contains all expected fields when a model is instantiated.init_device_config.pyparses thisdevice_config.jsonand for every model, instantiates the model and callload_model()andunload_model().model_factory.pyhas been modified to look upmodel_keyin device config instead of hard coded mappings.