Use NativeSumcheck for calculating initial_sum
#1249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 29, 2026
Collaborator
|
Please check scroll-tech/openvm#30 for new semantic of |
Collaborator
|
Previously, the "cuda" feature of openvm |
Collaborator
Collaborator
kunxian-xia
reviewed
Feb 11, 2026
Comment on lines
+173
to
+185
| let idx: Usize<C::N> = builder.eval(C::N::ONE); | ||
| builder | ||
| .range(0, num_prod_spec.clone()) | ||
| .for_each(|idx_vec, builder| { | ||
| let e = builder.get(&sumcheck_out, idx.clone()); | ||
| builder.set( | ||
| &prod_spec_point_n_eval, | ||
| idx_vec[0], | ||
| PointAndEvalVariable { | ||
| point: PointVariable { | ||
| fs: initial_rt.clone(), | ||
| }, | ||
| eval: e, |
kunxian-xia
reviewed
Feb 11, 2026
Comment on lines
+515
to
+517
| pub r_out_evals: Array<C, Ext<C::F, C::EF>>, | ||
| pub w_out_evals: Array<C, Ext<C::F, C::EF>>, | ||
| pub lk_out_evals: Array<C, Ext<C::F, C::EF>>, |
Collaborator
There was a problem hiding this comment.
the type should be HintSlice.
kunxian-xia
reviewed
Feb 11, 2026
| builder.set(&input_ctx, 5, Usize::from(1)); | ||
| builder.set(&input_ctx, 6, Usize::from(4)); | ||
| builder.set(&input_ctx, 7, Usize::from(0)); | ||
| builder.set(&input_ctx, 8, Usize::from(999)); |
Collaborator
There was a problem hiding this comment.
we need to read from hint space to fetch the raw prod_out_evals / logup_out_evals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimization for Calculating Initial Sum in tower verify.
initial_sum. UseNativeSumcheckinstead.Optimization for
NativeSumcheckNativeSumcheckchip that allows passing in hint space IDs for evaluation inputs instead of loading concrete witness arrays. This significantly reduces cycles involved in loading witnesses.