Fix messy progress bar in dump_range#155
Merged
Conversation
lightsing
requested changes
Nov 24, 2025
Member
lightsing
left a comment
There was a problem hiding this comment.
could you also add .inspect(|e| dev_error!("{e}")) to L123 and L129 so we can see the actual error.
lightsing
reviewed
Nov 24, 2025
lightsing
requested changes
Nov 24, 2025
Member
|
let me take this pr from here. thx @roynalnaruto |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #151
The PR fixes the messy progress bar display in terminal when witnesses for a range of blocks are being dumped.
MultiProgressand adds eachProgressBarto itprintlnstokio::fsinstead ofstd::fsfor async writing to fileThe progress bar now updates the message on the same line (for each tokio task) instead of moving to the next line.
Terminal output from this approach seems much more cleaner and clearer.
Demo