Skip to content

perf: reduce JSX annotation string churn #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scttcper merged 3 commits into from
Mar 15, 2026
Merged

perf: reduce JSX annotation string churn #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e7395df
bump version
scttcper Jan 2, 2026
52951f9
perf: reduce JSX annotation string churn
scttcper Mar 15, 2026
4f0dd0a
perf: satisfy clippy on styled attr allocation
scttcper Mar 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "swc-plugin-component-annotate",
"version": "1.12.0",
"version": "1.13.0",
"description": "Use SWC to automatically annotate React components with data attributes for component tracking",
"author": "scttcper <scttcper@gmail.com>",
"license": "MIT",
Expand Down
245 changes: 125 additions & 120 deletions src/constants.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,125 +1,130 @@
use rustc_hash::FxHashSet;
use std::sync::OnceLock;

pub fn default_ignored_elements() -> FxHashSet<&'static str> {
let mut set = FxHashSet::default();
let elements = [
"a",
"abbr",
"address",
"area",
"article",
"aside",
"audio",
"b",
"base",
"bdi",
"bdo",
"blockquote",
"body",
"br",
"button",
"canvas",
"caption",
"cite",
"code",
"col",
"colgroup",
"data",
"datalist",
"dd",
"del",
"details",
"dfn",
"dialog",
"div",
"dl",
"dt",
"em",
"embed",
"fieldset",
"figure",
"footer",
"form",
"h1",
"h2",
"h3",
"h4",
"h5",
"h6",
"head",
"header",
"hgroup",
"hr",
"html",
"i",
"iframe",
"img",
"input",
"ins",
"kbd",
"keygen",
"label",
"legend",
"li",
"link",
"main",
"map",
"mark",
"menu",
"menuitem",
"meter",
"nav",
"noscript",
"object",
"ol",
"optgroup",
"option",
"output",
"p",
"param",
"pre",
"progress",
"q",
"rb",
"rp",
"rt",
"rtc",
"ruby",
"s",
"samp",
"script",
"section",
"select",
"small",
"source",
"span",
"strong",
"style",
"sub",
"summary",
"sup",
"table",
"tbody",
"td",
"template",
"textarea",
"tfoot",
"th",
"thead",
"time",
"title",
"tr",
"track",
"u",
"ul",
"var",
"video",
"wbr",
];
pub fn default_ignored_elements() -> &'static FxHashSet<&'static str> {
static SET: OnceLock<FxHashSet<&'static str>> = OnceLock::new();

for element in elements {
set.insert(element);
}
SET.get_or_init(|| {
let mut set = FxHashSet::default();
let elements = [
"a",
"abbr",
"address",
"area",
"article",
"aside",
"audio",
"b",
"base",
"bdi",
"bdo",
"blockquote",
"body",
"br",
"button",
"canvas",
"caption",
"cite",
"code",
"col",
"colgroup",
"data",
"datalist",
"dd",
"del",
"details",
"dfn",
"dialog",
"div",
"dl",
"dt",
"em",
"embed",
"fieldset",
"figure",
"footer",
"form",
"h1",
"h2",
"h3",
"h4",
"h5",
"h6",
"head",
"header",
"hgroup",
"hr",
"html",
"i",
"iframe",
"img",
"input",
"ins",
"kbd",
"keygen",
"label",
"legend",
"li",
"link",
"main",
"map",
"mark",
"menu",
"menuitem",
"meter",
"nav",
"noscript",
"object",
"ol",
"optgroup",
"option",
"output",
"p",
"param",
"pre",
"progress",
"q",
"rb",
"rp",
"rt",
"rtc",
"ruby",
"s",
"samp",
"script",
"section",
"select",
"small",
"source",
"span",
"strong",
"style",
"sub",
"summary",
"sup",
"table",
"tbody",
"td",
"template",
"textarea",
"tfoot",
"th",
"thead",
"time",
"title",
"tr",
"track",
"u",
"ul",
"var",
"video",
"wbr",
];

set
for element in elements {
set.insert(element);
}

set
})
}
78 changes: 55 additions & 23 deletions src/jsx_utils.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,11 @@ use swc_core::ecma::ast::*;
pub fn is_react_fragment(element: &JSXElementName) -> bool {
match element {
JSXElementName::Ident(ident) => ident.sym.as_ref() == "Fragment",
JSXElementName::JSXMemberExpr(member_expr) => {
// Check for React.Fragment
if let JSXObject::Ident(obj) = &member_expr.obj {
if obj.sym.as_ref() == "React" {
return member_expr.prop.sym.as_ref() == "Fragment";
}
}
false
}
JSXElementName::JSXMemberExpr(member_expr) => matches!(
&member_expr.obj,
JSXObject::Ident(obj)
if obj.sym.as_ref() == "React" && member_expr.prop.sym.as_ref() == "Fragment"
),
JSXElementName::JSXNamespacedName(_) => false,
#[cfg(swc_ast_unknown)]
_ => panic!("unknown jsx element name"),
Expand All @@ -39,28 +35,42 @@ pub fn get_element_name(element: &JSXElementName) -> Cow<str> {

/// Recursively build the name for member expressions (e.g., "Components.UI.Button")
fn get_member_expression_name(member_expr: &JSXMemberExpr) -> String {
let obj_name = match &member_expr.obj {
JSXObject::Ident(ident) => ident.sym.as_ref(),
JSXObject::JSXMemberExpr(nested_member) => {
return format!(
"{}.{}",
get_member_expression_name(nested_member),
member_expr.prop.sym
);
fn member_expression_name_len(member_expr: &JSXMemberExpr) -> usize {
let obj_len = match &member_expr.obj {
JSXObject::Ident(ident) => ident.sym.len(),
JSXObject::JSXMemberExpr(nested_member) => member_expression_name_len(nested_member),
#[cfg(swc_ast_unknown)]
_ => panic!("unknown jsx object"),
};

obj_len + 1 + member_expr.prop.sym.len()
}

fn push_member_expression_name(target: &mut String, member_expr: &JSXMemberExpr) {
match &member_expr.obj {
JSXObject::Ident(ident) => target.push_str(ident.sym.as_ref()),
JSXObject::JSXMemberExpr(nested_member) => {
push_member_expression_name(target, nested_member);
}
#[cfg(swc_ast_unknown)]
_ => panic!("unknown jsx object"),
}
#[cfg(swc_ast_unknown)]
_ => panic!("unknown jsx object"),
};

format!("{}.{}", obj_name, member_expr.prop.sym)
target.push('.');
target.push_str(member_expr.prop.sym.as_ref());
}

let mut output = String::with_capacity(member_expression_name_len(member_expr));
push_member_expression_name(&mut output, member_expr);
output
}

/// Check if a JSX element already has an attribute with the given name
#[inline]
pub fn has_attribute(element: &JSXOpeningElement, attr_name: &str) -> bool {
element.attrs.iter().any(|attr| {
matches!(attr, JSXAttrOrSpread::JSXAttr(jsx_attr)
if matches!(&jsx_attr.name, JSXAttrName::Ident(ident)
matches!(attr, JSXAttrOrSpread::JSXAttr(jsx_attr)
if matches!(&jsx_attr.name, JSXAttrName::Ident(ident)
if ident.sym.as_ref() == attr_name))
})
}
Expand All @@ -78,3 +88,25 @@ pub fn create_jsx_attr(name: &str, value: &str) -> JSXAttrOrSpread {
})),
})
}

#[inline]
pub fn create_jsx_attr_with_ident(name: &IdentName, value: &str) -> JSXAttrOrSpread {
JSXAttrOrSpread::JSXAttr(JSXAttr {
span: Default::default(),
name: JSXAttrName::Ident(name.clone()),
value: Some(JSXAttrValue::Str(Str {
span: Default::default(),
value: value.into(),
raw: None,
})),
})
}

#[inline]
pub fn create_jsx_attr_with_ident_and_str(name: &IdentName, value: &Str) -> JSXAttrOrSpread {
JSXAttrOrSpread::JSXAttr(JSXAttr {
span: Default::default(),
name: JSXAttrName::Ident(name.clone()),
value: Some(JSXAttrValue::Str(value.clone())),
})
}
Loading
Loading