fix!: remove __delitem__ and __setitem__ from the AnnData object#2367
Open
fix!: remove __delitem__ and __setitem__ from the AnnData object#2367
__delitem__ and __setitem__ from the AnnData object#2367Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2367 +/- ##
==========================================
- Coverage 87.36% 85.60% -1.76%
==========================================
Files 49 49
Lines 7787 7766 -21
==========================================
- Hits 6803 6648 -155
- Misses 984 1118 +134
|
ilan-gold
changed the title
__delitem__ and __setitem__ from the AnnData object__delitem__ and __setitem__ from the AnnData object
ilan-gold
changed the title
__delitem__ and __setitem__ from the AnnData object__delitem__ and __setitem__ from the AnnData object
ilan-gold
commented
Mar 18, 2026
| with: | ||
| filters: | # this is intentionally a string | ||
| relnotes: 'docs/release-notes/${{ github.event.pull_request.number }}.${{ needs.check-milestone.outputs.type }}.md' | ||
| relnotes: 'docs/release-notes/${{ github.event.pull_request.number }}.${{ (contains(github.event.pull_request.title, '!') && 'breaking') || needs.check-milestone.outputs.type }}.md' |
Contributor
Author
There was a problem hiding this comment.
No better way to test/figure this out than a real PR
Member
There was a problem hiding this comment.
I think this is basically the logic yeah!
2 tasks
flying-sheep
approved these changes
Mar 20, 2026
| with: | ||
| filters: | # this is intentionally a string | ||
| relnotes: 'docs/release-notes/${{ github.event.pull_request.number }}.${{ needs.check-milestone.outputs.type }}.md' | ||
| relnotes: 'docs/release-notes/${{ github.event.pull_request.number }}.${{ (contains(github.event.pull_request.title, '!') && 'breaking') || needs.check-milestone.outputs.type }}.md' |
Member
There was a problem hiding this comment.
I think this is basically the logic yeah!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards making
backedmode simpler, we remove these two methodsbackedinternal checking #2369