validator: add filtering tests that were removed from test.py#435
Conversation
There was a problem hiding this comment.
Pull request overview
Adds back filtering-focused validator coverage that previously existed in test.py, ensuring ANN query filtering behavior stays regression-tested as filtering support evolves (VECTOR-479).
Changes:
- Registers two additional filtering test cases in the validator test suite.
- Adds a new test validating ANN queries filtered only by clustering key (
ck) return only matching rows (with and withoutALLOW FILTERING). - Adds a new test asserting ANN queries filtered by an indexed non-primary-key column are still rejected (even with
ALLOW FILTERING).
d849b0e to
3922f91
Compare
|
Hi guys, I was adding pre-filtering (filtering on the vector store side) and projection (returning filtering columns together with the result) to Alternator, and I discovered that filtering was only partially implemented in the vector store, and fixed it and expanded it in the following PR: #444 Now I'm worried that maybe I've been colliding with some unmerged work that you guys are doing in parallel :-( Can you please take a look? |
I left some comments on #444. I think this falls under the scope of VECTOR-561, which is assigned to @ewienik , but I don't see any associated development branch. |
We add two test cases from test.py that were removed when filtering support was added. We change the ck test, as now we support it. Fixes: VECTOR-479 Co-authored-by: Copilot <copilot@github.com>
3922f91 to
599924d
Compare
|
Changelog:
|
We add two test cases from test.py that were removed when filtering support was added. We change the ck test, as now we support it.
Fixes: VECTOR-479