Skip to content

validator: add filtering tests that were removed from test.py#435

Merged
ewienik merged 1 commit into
scylladb:masterfrom
smoczy123:check_filtering
May 14, 2026
Merged

validator: add filtering tests that were removed from test.py#435
ewienik merged 1 commit into
scylladb:masterfrom
smoczy123:check_filtering

Conversation

@smoczy123

Copy link
Copy Markdown
Collaborator

We add two test cases from test.py that were removed when filtering support was added. We change the ck test, as now we support it.

Fixes: VECTOR-479

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds back filtering-focused validator coverage that previously existed in test.py, ensuring ANN query filtering behavior stays regression-tested as filtering support evolves (VECTOR-479).

Changes:

  • Registers two additional filtering test cases in the validator test suite.
  • Adds a new test validating ANN queries filtered only by clustering key (ck) return only matching rows (with and without ALLOW FILTERING).
  • Adds a new test asserting ANN queries filtered by an indexed non-primary-key column are still rejected (even with ALLOW FILTERING).

Comment thread crates/validator/src/filtering.rs Outdated
Comment thread crates/validator/src/filtering.rs Outdated
Comment thread crates/validator/src/filtering.rs Outdated
knowack1
knowack1 previously approved these changes May 4, 2026
Comment thread crates/validator/src/filtering.rs Outdated
Comment thread crates/validator/src/filtering.rs Outdated
Comment thread crates/validator/src/filtering.rs Outdated
@smoczy123 smoczy123 force-pushed the check_filtering branch 3 times, most recently from d849b0e to 3922f91 Compare May 11, 2026 09:46
@smoczy123 smoczy123 requested a review from ewienik May 11, 2026 10:09
Comment thread crates/validator/src/filtering.rs Outdated
Comment thread crates/validator/src/filtering.rs Outdated
@nyh

nyh commented May 11, 2026

Copy link
Copy Markdown
Contributor

Hi guys, I was adding pre-filtering (filtering on the vector store side) and projection (returning filtering columns together with the result) to Alternator, and I discovered that filtering was only partially implemented in the vector store, and fixed it and expanded it in the following PR: #444

Now I'm worried that maybe I've been colliding with some unmerged work that you guys are doing in parallel :-(

Can you please take a look?

@knowack1

Copy link
Copy Markdown
Collaborator

Hi guys, I was adding pre-filtering (filtering on the vector store side) and projection (returning filtering columns together with the result) to Alternator, and I discovered that filtering was only partially implemented in the vector store, and fixed it and expanded it in the following PR: #444

Now I'm worried that maybe I've been colliding with some unmerged work that you guys are doing in parallel :-(

Can you please take a look?

I left some comments on #444. I think this falls under the scope of VECTOR-561, which is assigned to @ewienik , but I don't see any associated development branch.

We add two test cases from test.py that were removed when filtering support was added. We change the ck test, as now we support it.

Fixes: VECTOR-479

Co-authored-by: Copilot <copilot@github.com>
@smoczy123

Copy link
Copy Markdown
Collaborator Author

Changelog:

@ewienik ewienik added this pull request to the merge queue May 14, 2026
Merged via the queue into scylladb:master with commit 34f7757 May 14, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants