Fix error when instantiating IndexedControlValue#12
Open
jpburstrom wants to merge 6 commits into
Open
Conversation
Changing defaultSpec from ItemsSpec to ItemSpec (ItemsSpec is in Modality Toolkit but not a Connection dependency)
Throwing error when items doesn't include value
Making it possible to use arbitrary values as on/off states. This will throw if instantiated with a non-existing value. This changes the behaviour of input_: input argument above *and including* 0.5 will set value to \on.
Fix making new connection after freeing previous connections
Make UpdateFilter and UpdateTransform subclass UpdateForwarderWithInit, which keeps track of last object sending a \changed message. Everytime a dependant is added to the forwarder, this object is asked to resend its value. This is a bit of a kludge, but fixes forwarding initial values through a chain of several forwarders, which would otherwise stop at first UpdateForwarder subclass when the value is sent before the dependency chain is ready. The value will be sent once for every link in the forwarder chain, which might build up and cause issues for complex chains.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing *defaultSpec from
ItemsSpec(which is probably a typo) toItemSpec. (ItemsSpecis in Modality Toolkit but that's not a Connection dependency.)