Closed
Conversation
…t test for snapshot reload
…storage engine snapshot
Contributor
|
Open a separate PR for hnsw index(checked out from hnsw branch) |
Member
Author
|
Opened another PR (#67) from a cleaner branch that is up to date with refactor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #38
Currently based on top of the
kd_tree_refactorbranch.TODO:
FlatIndexKDTreeHNSWIndex- waiting on other restructuring changesStorageEngine(only rocksdb as of now)snapshotcrate that creates and restores a snapshot tarball including:StorageEnginecheckpoint, snapshot of Index topology from the serialized bytes, snapshot of the metadata of the Index,manifest.jsoncontaining checksums and other information needed for restore.SnapshotRegistrythat is responsible for storing and managing snapshot files. - CurrentlyLocalRegistryis implemented which just stores the snapshots in a directory but in the future aRemoteRegistrycan be created that implements theSnapshotRegistrytrait.SnapshotEnginethat manages a registry of snapshots and spawns a worker thread that periodically takes snapshots of the database and adds it to the registry.apicrate to take and restore snapshotsgrpccrate and configuration options that actually exposes these methods to users.