beast/v2 by sukhman-sukh · Pull Request #393 · sdslabs/beast

sukhman-sukh · 2025-02-12T18:28:57Z

No description provided.

Co-authored-by: vibhatsu <152148244+v1bh475u@users.noreply.github.com>

Signed-off-by: ayu-ch <ayu.chandekar@gmail.com>

…r consistency Signed-off-by: Praneeth Sarode <praneethsarode@gmail.com>

Migrate to postgres and modify models for consistency

Frontend compatibilty fixes

Copilot

Pull request overview

This PR introduces significant architectural changes to migrate Beast from SQLite to PostgreSQL, implements remote server deployment capabilities, adds OTP-based email verification, and enhances the leaderboard system with frozen scores and time-series data visualization.

Key Changes:

Migration from SQLite to PostgreSQL with comprehensive database backup/restore functionality
Remote server deployment support via SSH with load balancing across multiple servers
OTP-based email verification for user registration and password recovery
Enhanced leaderboard with frozen scoring, pagination, and time-series graph data for top users
Challenge hints system with point-based cost and attempt limits

Reviewed changes

Copilot reviewed 72 out of 2151 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
core/database/database.go	Migrated from SQLite to PostgreSQL with backup/restore capabilities
pkg/remoteManager/*.go	Added remote server management for distributed challenge deployment
api/otp.go	Implemented OTP-based email verification system
core/database/hints.go	Added hints system with point-based unlocking
api/info.go	Enhanced leaderboard with frozen scores and time-series data
core/database/challenges.go	Added challenge attempt limits, prerequisites, and solve tracking
utils/prompt.go	Added interactive CLI prompts for configuration
cmd/beast/init.go	Comprehensive initialization with database and config setup
go.mod	Updated Go version to 1.22.0 and dependencies

Comments suppressed due to low confidence (1)

api/submit.go:1

String concatenation should use fmt.Sprintf for better readability and maintainability, especially with multiple variables.

package api

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-16T08:52:08Z

utils/file.go

 		if e != nil {
-			eMsg := fmt.Errorf("Could not create file : %s", filePath)
+			eMsg := fmt.Errorf("could not create file : %s", filePath)
 			return eMsg
 		}
+		defer file.Close()


The defer statement for file.Close() is positioned after the error check, meaning the file will not be closed if an error occurs. Move the defer statement immediately after the file assignment to ensure proper resource cleanup even in error cases.

Copilot · 2025-12-16T08:52:08Z

pkg/remoteManager/init.go

+			defer client.Close()
+			ServerQueue.Push(server)
+			RunCommandOnServer(server, "mkdir -p $HOME/.beast/staging/")


The defer statement is inside a loop, which means client.Close() will only be called when Init() returns, not after each iteration. This will leave SSH connections open until the function exits. Move client.Close() outside the defer to close it immediately after use within the loop iteration.

Suggested change

defer client.Close()

ServerQueue.Push(server)

RunCommandOnServer(server, "mkdir -p $HOME/.beast/staging/")

ServerQueue.Push(server)

RunCommandOnServer(server, "mkdir -p $HOME/.beast/staging/")

client.Close()

Copilot · 2025-12-16T08:52:09Z

core/database/challenges.go

+	start, err := dateparse.ParseLocal(startParseStr)
+	if err != nil {
+		log.Errorf("failed to parse StartingTime: %v", err)
+		return Between1MonthAnd1Year
+	}


The error handling returns a default time bucket (Between1MonthAnd1Year) on parsing failure, which could mask configuration errors. Consider returning a specific error bucket or logging more context about why parsing failed.

Copilot · 2025-12-16T08:52:09Z

api/otp.go

+
+	// Setup TLS connection
+	tlsConfig := &tls.Config{
+		InsecureSkipVerify: true, // Set true only if SMTP server uses self-signed certs


InsecureSkipVerify is set to true, which disables TLS certificate verification and makes the connection vulnerable to man-in-the-middle attacks. This should be set to false in production or made configurable.

Suggested change

InsecureSkipVerify: true, // Set true only if SMTP server uses self-signed certs

InsecureSkipVerify: false, // Do not skip verification; secure by default

Copilot · 2025-12-16T08:52:09Z

core/manager/health_check.go

+		if server.Active && server.Host != core.LOCALHOST {
+			err := remoteManager.PingServer(server)
+			if err != nil {
+				msg := fmt.Sprintf("SERVER HEALTH CHECK Faliure: %s : %s", server.Host, err)


Corrected spelling of 'Faliure' to 'Failure'.

Suggested change

msg := fmt.Sprintf("SERVER HEALTH CHECK Faliure: %s : %s", server.Host, err)

msg := fmt.Sprintf("SERVER HEALTH CHECK Failure: %s : %s", server.Host, err)

cmd/beast/init.go

Copilot · 2025-12-16T08:52:10Z

api/info.go

 	if chall == "" {
 		c.JSON(http.StatusBadRequest, HTTPPlainResp{
-			Message: fmt.Sprintf("Challenge name cannot be empty"),
+			Message: fmt.Sprint("challenge name cannot be empty"),


Using fmt.Sprint with a single string argument is unnecessary. The string can be used directly without formatting.

Suggested change

Message: fmt.Sprint("challenge name cannot be empty"),

Message: "challenge name cannot be empty",

* add beast init check in beast run * use core contants for paths * remove unused init and initDirectory from main * use os.IsNotExist * add beast secrets dir * add authorized keys * add beast example config file * rename detauklt auth keys file * add examples directory * add default beast db credentials * add beast init * add prompt for database creation, add prompt for admin creation * add docker pid check, change y\n prompt options * change created beast directory info message * change beast directory not found commit message * add beast bootsteps complete and start beast server message * add ANSI sequence macros * add notification services to constants * add prompt utils * add prompting configuration through terminal * add beast config command * change config command description * bug fixes on git config * fix bugs in beast init * add database prompt to beast config * add user friendly prompt for date time * bug fixes on prompt date * Add check to try connect as postgres super user if possible and resort to password otherwise * Fix: use username instead * Fix: sanitise postgres queries wherever possible * Refactor: make 'promptDatabaseConnectionDetails' function explicit * Fix: Add prompt db name in 'promptDatabaseConnectionDetails' * Refactor: remove unnecessary interpolation * Refactor: fix typo * Fix: add default value checks for connection details * Cleanup: Remove duplicate 'initAuthorizedKeysFile' call. * Refactor: fix interchange between prompts and add minimum memory check. * Feat: Add copy ssh key to authorized keys file. * Fix: create beast example directory if not exists. * Fix: fix infinite loop by calling admin creation directly. * Fix: change ssh permissions * Refactor: substitute deprceated ioutil function for os.ReadFile * Fix: Use TUI for picking public key files and add checks for initialising admin. * Fix: Add change password for beast postgres user. * Refactor: Print log if key file not found instead of error.

* add warning instead of error on empty integer input * Add dbUserCheck function: checks if current user is postgres super user # Conflicts: # cmd/beast/init.go * Add check to try connect as postgres super user if possible and resort to password otherwise * add defer close client * move newTask into scope * add creation of beast cache folder in beast init * remove primary cleanup from utils * add remote manager stop to pop servers * add cleanup and rebase issue 417 * move cache save before database termination * remove unused function * remove cyclic dependancy * Add comments and explain why 'cleanup' is outside 'core/utils/cleanup.go' * Fix: fix typos and frozen leaderboard limit

* feat(ChallengeEnv): DockerCompose field Signed-off-by: vibhatsu <maulikbarot2915@gmail.com> * add(stageChallenge): support for docker-compose Signed-off-by: vibhatsu <maulikbarot2915@gmail.com> * fix(errors): standardize error messages Signed-off-by: vibhatsu <maulikbarot2915@gmail.com> * fix(errors): standardize error messages Signed-off-by: vibhatsu <maulikbarot2915@gmail.com> * feat(docker-compose): add deploy, undeploy and purge functions for local Signed-off-by: vibhatsu <maulikbarot2915@gmail.com> * feat(build-images): BuildImagesFromCompose Signed-off-by: vibhatsu <maulikbarot2915@gmail.com> * feat(remote-manager): add BulidImageFromComposeRemote function for compose build Signed-off-by: vibhatsu <maulikbarot2915@gmail.com> * feat(remote-manager): add deploy, undeploy and purge functions for remote DockerCompose management Signed-off-by: vibhatsu <maulikbarot2915@gmail.com> * feat(pipeline): enhnace docker dompose support for challenge staging and deployment Signed-off-by: vibhatsu <maulikbarot2915@gmail.com> * feat(challenge-manager): enhance undeploy logic for docker compose Signed-off-by: vibhatsu <maulikbarot2915@gmail.com> * add: docker compose example Signed-off-by: vibhatsu <maulikbarot2915@gmail.com> * refactor(deploy): remove success log for docker-compose up and down commands Signed-off-by: vibhatsu <maulikbarot2915@gmail.com> * refactor(pipeline): remove validation of docker-compose file Signed-off-by: vibhatsu <maulikbarot2915@gmail.com> * update(README): add description of docker compose challenge Signed-off-by: vibhatsu <maulikbarot2915@gmail.com> * fix: correct typos in comments and log messages Signed-off-by: vibhatsu <maulikbarot2915@gmail.com> * refactor(docker-commpose): reduce example Signed-off-by: vibhatsu <maulikbarot2915@gmail.com> * fix: improve error logging and formatting in cleanup and show functions Signed-off-by: vibhatsu <maulikbarot2915@gmail.com> * feat(docker-compose): add validation for docker_compose config and warnings Signed-off-by: vibhatsu <maulikbarot2915@gmail.com> * feat(docker-compose): add deployment type support Signed-off-by: vibhatsu <maulikbarot2915@gmail.com> * feat(docker-compose): enhance container deployment verification and error handling Signed-off-by: vibhatsu <maulikbarot2915@gmail.com> * fix(database): improve error messages in transactions Signed-off-by: vibhatsu <maulikbarot2915@gmail.com> * fix(compose-type): correct toml fields Signed-off-by: vibhatsu <maulikbarot2915@gmail.com> * fix(pipeline): correct the deploy logic after rebase Signed-off-by: vibhatsu <maulikbarot2915@gmail.com> * fix(config): return early for docker compose type challenge Signed-off-by: vibhatsu <maulikbarot2915@gmail.com> * feat(compose): enhance deployment and cleanup processes for Docker Compose Signed-off-by: vibhatsu <maulikbarot2915@gmail.com> * feat(compose): enhance remote deployment and cleanup processes for Docker Compose Signed-off-by: vibhatsu <maulikbarot2915@gmail.com> * feat(pipeline): enhance Docker Compose deployment with primary container ID tracking Signed-off-by: vibhatsu <maulikbarot2915@gmail.com> * feat(cleanup): implement label-based cleanup for Docker Compose challenges Signed-off-by: vibhatsu <maulikbarot2915@gmail.com> * feat(project): add GetProjectName function for standardized project naming Signed-off-by: vibhatsu <maulikbarot2915@gmail.com> * feat(labels): add standardized labels for Docker containers and images using GetProjectName Signed-off-by: vibhatsu <maulikbarot2915@gmail.com> * feat(cleanup): update logging for Docker Compose challenge cleanup and use GetProjectName for project naming Signed-off-by: vibhatsu <maulikbarot2915@gmail.com> * feat(cleanup): remove fallback to label-based cleanup Signed-off-by: vibhatsu <maulikbarot2915@gmail.com> --------- Signed-off-by: vibhatsu <maulikbarot2915@gmail.com>

* Fix: fix password quoting * Add: Set postgres user as owner of postgres database

* Add sse notification service in pkg/sse and setup streaming route * Fix send notification to all clients via NotifyChan of each connected client * Refact remove unused fields and types * Refact remove unecessary mutex in the HUB * Fix send notification after saving in the database * Fix use uuid for id of connected sse clients * Fix remaining concurrency issues * Add Sse Hub graceful shutdown in cleanup

Signed-off-by: vibhatsu <maulikbarot2915@gmail.com>

chore: sidecar removal

sukhman-sukh and others added 30 commits January 9, 2025 16:13

Fix warnings and setup configs

d6876e2

Adds feature: Limit the max amount of tries on challenge

54170c2

Code formatting

fa5817b

Fix: Bug in challenge solve status

8ddc848

Adds feature: Chain challenges to create pre requisite challenges

5f647ea

feat: adds paid hints

477093c

Changes to copy from move in setup script

7881c23

Add deploy feature for multi instance and reset-database command

d26aed0

PR fixes

749cc37

Add container and image management feature for remote

f0bfafd

Add remote container/image filter and removal

09c1fa9

Serve static files

66e5e2c

Add health checker for local and remote challs

8102509

Fix remote containers filter function

b9c9367

Fix static file serving

72a952d

Fix edgecases

3244a4b

Fix chal.ServerDeployed and AdditionalLinks

7821d53

Update pkg/notify/main.go

ec12b6a

Co-authored-by: vibhatsu <152148244+v1bh475u@users.noreply.github.com>

Change strings to global var

7409bbc

Merge branch 'master' into multiple_servers

66a8154

Merge branch 'multiple_servers' into serve_static_files

fea3b19

Change paid hints logic, updated handler to display hints

ea4ad13

Signed-off-by: ayu-ch <ayu.chandekar@gmail.com>

Fix free redeem on post

3ecaeaa

Signed-off-by: ayu-ch <ayu.chandekar@gmail.com>

SMTP integration

363ceaf

Adds SMTP toml creation and email-template path

c546f91

Add deployed links

2ec0e45

Adds path creation for email template

9fbcf72

Fix error which returns every attempt as solved

02d3c30

Signed-off-by: ayu-ch <ayu.chandekar@gmail.com>

SMTP changes for IITR

5cf4fc1

Route change for sending OTP

bc6184e

sukhman-sukh and others added 10 commits August 13, 2025 23:45

Add backup and reset db

7695654

feat: migrate to postgres and refactor database models and queries fo…

4a8d8af

…r consistency Signed-off-by: Praneeth Sarode <praneethsarode@gmail.com>

Fix database init errors

7b3d0c2

Fix flags

0b132d9

Merge pull request #413 from sdslabs/db_migration

eaebedd

Migrate to postgres and modify models for consistency

Make JSON Responses compatible

5166f5c

Add graph support to beast backend

03d5104

Resolve copilot suggestions

6873293

Merge pull request #420 from sdslabs/frontend_compatibilty_fixes

5b6da93

Frontend compatibilty fixes

Add cache invalidation to graph

48dc9ff

Copilot AI review requested due to automatic review settings December 16, 2025 08:44

Copilot AI reviewed Dec 16, 2025

View reviewed changes

v1bh475u added the beast/v2 label Dec 16, 2025

v1bh475u changed the title ~~Bl4ze/dev~~ beast/v1 Dec 16, 2025

v1bh475u force-pushed the bl4ze/dev branch from 234f039 to 48dc9ff Compare December 16, 2025 10:51

peopleig and others added 2 commits December 20, 2025 15:51

Add container naming convention for challenges (#429)

b025451

v1bh475u changed the title ~~beast/v1~~ beast/v2 Jan 15, 2026

v1bh475u force-pushed the bl4ze/dev branch from a59d30d to 30cbfa6 Compare January 26, 2026 15:40

v1bh475u and others added 10 commits January 26, 2026 21:11

fix(cleanup): API scheduler goroutine call once

9c59c49

Fix: fix password quoting

72316b8

* Fix: fix password quoting * Add: Set postgres user as owner of postgres database

chore: remove purely sidecar related files

f828f86

Signed-off-by: vibhatsu <maulikbarot2915@gmail.com>

refactor: remove sidecar references and related code

27fc4bd

Signed-off-by: vibhatsu <maulikbarot2915@gmail.com>

docs: mark sidecar references as deprecated in documentation

a6e96ce

Signed-off-by: vibhatsu <maulikbarot2915@gmail.com>

fix: update mod file

fc97e5f

Signed-off-by: vibhatsu <maulikbarot2915@gmail.com>

chore: remove sidecar references and related files from the codebase

41bf29e

Signed-off-by: vibhatsu <maulikbarot2915@gmail.com>

Merge pull request #424 from sdslabs/chore/sidecar-removal

7a89db8

chore: sidecar removal

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

beast/v2#393

beast/v2#393
sukhman-sukh wants to merge 155 commits intomasterfrom
bl4ze/dev

sukhman-sukh commented Feb 12, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Dec 16, 2025

Uh oh!

Copilot AI Dec 16, 2025

Uh oh!

Copilot AI Dec 16, 2025

Uh oh!

Copilot AI Dec 16, 2025

Uh oh!

Copilot AI Dec 16, 2025

Uh oh!

Uh oh!

Copilot AI Dec 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

	InsecureSkipVerify: true, // Set true only if SMTP server uses self-signed certs
	InsecureSkipVerify: false, // Do not skip verification; secure by default

	msg := fmt.Sprintf("SERVER HEALTH CHECK Faliure: %s : %s", server.Host, err)
	msg := fmt.Sprintf("SERVER HEALTH CHECK Failure: %s : %s", server.Host, err)

	Message: fmt.Sprint("challenge name cannot be empty"),
	Message: "challenge name cannot be empty",

Conversation

sukhman-sukh commented Feb 12, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes:

Reviewed changes

Uh oh!

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants