Skip to content

platforms: add Pine64 Star64#283

Merged
lsf37 merged 1 commit intoseL4:masterfrom
Ivan-Velickovic:star64
Apr 16, 2026
Merged

platforms: add Pine64 Star64#283
lsf37 merged 1 commit intoseL4:masterfrom
Ivan-Velickovic:star64

Conversation

@Ivan-Velickovic
Copy link
Copy Markdown
Contributor

For once all the Star64 PRs are merged.

smp: [64]
platform: star64
req: [star64]
march: rv64imac
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what march does exactly here, march: rv64gcb would be more accurate for the Star64. The only use of march I can see is here

def getISA(self, mode: int) -> str:
"""Return the ISA for this platform"""
if self.arch == "x86":
return {32: "IA32", 64: "x86_64"}[mode]
if self.arch == "riscv":
return {32: "RC32IMAC", 64: "RV64IMAC"}[mode]
return self.march.capitalize()
, where it seems to be ignoring march anyways.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be wrong, but I think the only remaining use of march is for grouping in CI matrices. We could try to eliminate it and see what happens..

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a survey of this for PR #385 and it's a bit of work. So for now, to merge new platforms we should use the old rv64imac even if that is not accurate any more.

Copy link
Copy Markdown
Member

@lsf37 lsf37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Happy for you to merge once the other PRs are done.

(Ok to ignore the devscript link failure for this PR)

Comment thread seL4-platforms/platforms.yml Outdated
smp: [64]
platform: star64
req: [star64]
march: rv64imafdc
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now we still need the old version

Suggested change
march: rv64imafdc
march: rv64imac

Signed-off-by: Ivan-Velickovic <i.velickovic@unsw.edu.au>
@lsf37 lsf37 merged commit 5c04cc5 into seL4:master Apr 16, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants